-
Notifications
You must be signed in to change notification settings - Fork 30
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Updates to design + next.js implementation #7
Merged
Merged
Changes from 3 commits
Commits
Show all changes
62 commits
Select commit
Hold shift + click to select a range
272d813
integrate updates and refinements
8a6e234
Adapt code style
rgbkrk 8dc837b
remove unused dependencies
rgbkrk 89c239e
bump dependencies
rgbkrk 8e2a2a1
prefetch nteract.github.io, move up
rgbkrk 42e5c3e
remove unused navigation component
rgbkrk 7eee94f
extract buttons as components
rgbkrk db1a690
built out kernels, desktop pages and abstracted out a new component f…
187a85f
Extract a themeColor property for c/head/head
rgbkrk 3e65232
make kernels pages all keep the same header
rgbkrk 93a995f
created a working mobile menu
ded85f9
Merge branch 'updates-next' of github.com:nteract/nteract.io into upd…
5b78b8d
fix mobile menu bugs and adjust kernel page titles
8a721b0
minor mobile menu bugs
0c7645b
replace filler text with real prose
rgbkrk aae10c8
prep download button featurette
rgbkrk 4f94f33
extract DownloadFeaturette
rgbkrk 1f455c4
don't show mac as other when mac chosen
rgbkrk 3117761
move desktop page header into desktop
rgbkrk 4628de8
cleanup imports
rgbkrk e7e30d5
Introduce context type
rgbkrk 1a7aa9f
extract platform detection
rgbkrk 67aadfe
include comment for server vs. client side
rgbkrk 0666abe
remove unused styles
rgbkrk acfc9c0
fold main into home
rgbkrk 45a920f
bring home into index.js
rgbkrk 1514208
share os detection types across pages
rgbkrk 124d800
propagate platform through
rgbkrk 5f82707
fall back on navigator when necessary
rgbkrk 0ee927c
trim up the text
rgbkrk d89f59c
link to the latest release
rgbkrk 7562258
more flow, prettier
rgbkrk e9320a2
sneak in about and atom
rgbkrk e318906
rearrange, recolorize
rgbkrk 2b24959
Add initial content for Atom page
lgeiger 2e0343a
Add styling for links
lgeiger f03c463
Atom: Alternate images and text content
lgeiger b71fe18
Change Atom page title
lgeiger 0cf2b33
Fix styling for alternating content
lgeiger 6d28ae1
Atom: Add inspector section
lgeiger 5b8c7a1
Atom: Use <img/> instead of <image/>
lgeiger f88c59e
refinements
40dcfe6
resolve conflicts
032febd
updates to overall site, abstract out theme color for each page, adju…
2f4a002
updates to kernels page and more testing
19010fe
update deps and about page for deployment"
4f0b799
include the raw data from github
rgbkrk e98de7c
create single pages for kernels
58b8d9b
Merge branch 'updates-next' of github.com:nteract/nteract.io into upd…
253274d
refine kernels sub-pages
467d558
update button class
86073e0
bump nteract members
rgbkrk 52c3e0b
take out overexplanatory text
rgbkrk 23ddb16
bump nteract-members
rgbkrk 594fbcd
update about page
rgbkrk 754fc29
Atom: Use lower res videos
lgeiger 1f8334d
Contributors: Show github login if name is not available
lgeiger 8744b02
Fix social media button position
lgeiger c567fb5
Clean up R segment
rgbkrk 4ce0656
Merge pull request #11 from nteract/update-r-text
rgbkrk 35d878d
Merge pull request #10 from lgeiger/social-buttons
rgbkrk a46f3d6
Merge pull request #9 from lgeiger/gh-login
rgbkrk File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -3,7 +3,7 @@ import Head from "next/head"; | |
import LanguageToggle from "../kernels/language-toggle"; | ||
|
||
import Layout from "../layout/layout"; | ||
import ContentSection from "../content-section/content-section"; | ||
import { ContentSection } from "../content-section/content-section"; | ||
import PageHeader from "./page-header"; | ||
|
||
export type KernelPageProps = { | ||
|
@@ -17,12 +17,12 @@ export const kernels = [ | |
{ name: "node.js", path: "/kernels/node" } | ||
]; | ||
|
||
export default (props: KernelPageProps) => ( | ||
<Layout pageTitle={`: kernels - ${props.language}`}> | ||
export default (props: KernelPageProps, themeColor: '#444') => ( | ||
<Layout pageTitle={`: kernels - ${props.language}`} themeColor={themeColor}> | ||
<Head> | ||
<link rel="stylesheet" href="/static/kernels.css" /> | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Side note about next's |
||
</Head> | ||
<PageHeader /> | ||
<PageHeader themeColor={themeColor} /> | ||
<ContentSection> | ||
<header> | ||
<LanguageToggle current={props.language} kernels={kernels} /> | ||
|
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,18 +1,24 @@ | ||
import React from 'react' | ||
import Head from '../head/head' | ||
import Header from '../header/header' | ||
import Footer from '../footer/footer' | ||
import styles from './layout.scss' | ||
|
||
|
||
export default ({children, pageTitle}) => ( | ||
<div className="layout"> | ||
<style dangerouslySetInnerHTML={{__html: styles}}/> | ||
export default class Layout extends React.Component { | ||
|
||
<Head pageTitle={pageTitle}/> | ||
<Header /> | ||
<div className="page"> | ||
{ children } | ||
</div> | ||
<Footer /> | ||
</div> | ||
) | ||
render() { | ||
return ( | ||
<div className="layout"> | ||
<style dangerouslySetInnerHTML={{__html: styles}}/> | ||
|
||
<Head pageTitle={this.props.pageTitle}/> | ||
<Header themeColor={this.props.themeColor}/> | ||
<div className="page"> | ||
{ this.props.children } | ||
</div> | ||
<Footer /> | ||
</div> | ||
); | ||
} | ||
} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If we listen to events we'll want to remove the event listener on unmount.