client: Fix data stream len check for zero range case #692
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
3141d39 defect. Previously, when zero range (i.e. full payload) was requested, `client.Client` failed stream reader returned from `ObjectRangeInit` on 1st chunk receive. This was caused by the condition comparing number of bytes read against the requested one. For zero case, total length is unknown, so this check must not be done at all. This fixes the problem and adds corresponding unit test. Fixes #691. Signed-off-by: Leonard Lyubich <leonard@morphbits.io>
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #692 +/- ##
=======================================
Coverage 55.16% 55.16%
=======================================
Files 166 166
Lines 22739 22739
=======================================
Hits 12545 12545
Misses 9924 9924
Partials 270 270 ☔ View full report in Codecov by Sentry. |
cthulhu-rider
requested review from
roman-khimov,
smallhive and
carpawell
as code owners
roman-khimov
approved these changes
Mar 4, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.