Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix fetching bearer from cookie #179

Merged
merged 4 commits into from
Mar 21, 2024
Merged

Conversation

roman-khimov
Copy link
Member

No description provided.

http.Cookie doesn't need this processing inherited from fasthttp, it has
all the data already parsed. Old code couldn't get bearer token from cookie.

Signed-off-by: Roman Khimov <roman@nspcc.ru>
These dances don't make much sense.

Signed-off-by: Roman Khimov <roman@nspcc.ru>
They're not used outside the package.

Signed-off-by: Roman Khimov <roman@nspcc.ru>
Signed-off-by: Roman Khimov <roman@nspcc.ru>
@roman-khimov roman-khimov added this to the v0.8.2 milestone Mar 21, 2024
Copy link

codecov bot commented Mar 21, 2024

Codecov Report

Attention: Patch coverage is 0% with 6 lines in your changes are missing coverage. Please review.

Project coverage is 23.00%. Comparing base (23ec8ba) to head (3e4bb24).
Report is 1 commits behind head on master.

Files Patch % Lines
handlers/api.go 0.00% 6 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #179      +/-   ##
==========================================
+ Coverage   22.93%   23.00%   +0.07%     
==========================================
  Files          14       14              
  Lines        3575     3564      -11     
==========================================
  Hits          820      820              
+ Misses       2634     2623      -11     
  Partials      121      121              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@roman-khimov roman-khimov merged commit 424e137 into master Mar 21, 2024
10 of 11 checks passed
@roman-khimov roman-khimov deleted the fix-bearer-from-cookie branch March 21, 2024 10:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants