[#1133] services/session: remove expired tokens every epoch #1134
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #1134 +/- ##
==========================================
- Coverage 35.60% 35.56% -0.05%
==========================================
Files 283 285 +2
Lines 17915 17936 +21
==========================================
Hits 6379 6379
- Misses 11053 11074 +21
Partials 483 483
Continue to review full report at Codecov.
|
| @@ -49,3 +49,15 @@ func (s *TokenStore) Get(ownerID *owner.ID, tokenID []byte) *PrivateToken { | |||
|
|
|||
| return t | |||
| } | |||
|
|
|||
| // RemoveOld removes all expired tokens provided current epoch. | |||
There was a problem hiding this comment.
I'd say
Suggested change
| // RemoveOld removes all expired tokens provided current epoch. | |
| // RemoveOld removes all tokens expired since provided epoch. |
cthulhu-rider
approved these changes
Feb 4, 2022
cthulhu-rider
requested changes
Feb 4, 2022
| // RemoveOld removes all expired tokens provided current epoch. | ||
| func (s *TokenStore) RemoveOld(epoch uint64) { | ||
| s.mtx.Lock() | ||
| defer s.mtx.RUnlock() |
There was a problem hiding this comment.
Suggested change
| defer s.mtx.RUnlock() | |
| defer s.mtx.Unlock() |
Signed-off-by: Evgenii Stratonikov <evgeniy@nspcc.ru>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Evgenii Stratonikov evgeniy@nspcc.ru