Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Go 1.23 upgrade check list #2918

Closed
roman-khimov opened this issue Aug 14, 2024 · 1 comment
Closed

Go 1.23 upgrade check list #2918

roman-khimov opened this issue Aug 14, 2024 · 1 comment
Labels
enhancement Improving existing functionality go Go language related I4 No visible changes S3 Minimally significant U4 Nothing urgent
Milestone
v0.46.0

Comments

@roman-khimov
Copy link
Member

See nspcc-dev/neo-go#3553
@roman-khimov roman-khimov added blocked Can't be done because of something enhancement Improving existing functionality go Go language related I4 No visible changes S3 Minimally significant U4 Nothing urgent labels Aug 14, 2024
@roman-khimov
Copy link
Member Author

https://tip.golang.org/wiki/RangefuncExperiment can be useful for node iterators of various kinds (of which we have a lot here). It'll be the standard way to handle similar problems soon.

@roman-khimov roman-khimov added this to the v0.46.0 milestone Feb 14, 2025
@roman-khimov roman-khimov removed the blocked Can't be done because of something label Feb 14, 2025
@cthulhu-rider cthulhu-rider mentioned this issue Mar 4, 2025
Merged
cthulhu-rider added a commit that referenced this issue Mar 7, 2025
@cthulhu-rider
go.mod: Bump min required Go to 1.23
f95feb3 
Update GitHub workflows and Docker builders too.

Refs #2918.

Signed-off-by: Leonard Lyubich <leonard@morphbits.io>
cthulhu-rider added a commit that referenced this issue Mar 7, 2025
@cthulhu-rider
*: Do not stop timers and tickers for GC
de19721 
With Go 1.23 which is min required since f95feb3,
`Stop` is no longer required to be called for `Timer`/`Ticker` resource
collecting.

Refs #2918.

Signed-off-by: Leonard Lyubich <leonard@morphbits.io>
cthulhu-rider added a commit that referenced this issue Mar 7, 2025
@cthulhu-rider
*: Replace deprecated math/rand.Read with ChaCha8
5396b33 
With Go1.23 which is min required since f95feb3,
`rand/ChaCha8.Read` method is now available. It covers all current
testing purposes.

New `testutil` package collecting various Go test helpers has also been
created.

Refs ##2918.

Signed-off-by: Leonard Lyubich <leonard@morphbits.io>
cthulhu-rider added a commit that referenced this issue Mar 7, 2025
@cthulhu-rider
*: Compare strings using cmp.Compare
a731088 
Refs #2918.

Signed-off-by: Leonard Lyubich <leonard@morphbits.io>
cthulhu-rider added a commit that referenced this issue Mar 10, 2025
@cthulhu-rider
*: Use for-range loops over iterator functions
5059b3c 
Possible with Go 1.23 which is min required since f95feb3.

Closes #2918.

Signed-off-by: Leonard Lyubich <leonard@morphbits.io>
cthulhu-rider added a commit that referenced this issue Mar 10, 2025
@cthulhu-rider
*: Use for-range loops over iterator functions
b470836 
Possible with Go 1.23 which is min required since f95feb3.

Closes #2918.

Signed-off-by: Leonard Lyubich <leonard@morphbits.io>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement Improving existing functionality go Go language related I4 No visible changes S3 Minimally significant U4 Nothing urgent
Projects
None yet
Milestone
v0.46.0
Development

No branches or pull requests
1 participant
@roman-khimov