Skip to content
This repository was archived by the owner on Mar 19, 2024. It is now read-only.

[#30] Fix not found responses #80

Merged

Conversation

KirillovDenis
Copy link
Contributor

closes #30

Signed-off-by: Denis Kirillov denis@nspcc.ru

Signed-off-by: Denis Kirillov <denis@nspcc.ru>
@codecov
Copy link

codecov bot commented Jul 20, 2021

Codecov Report

Merging #80 (03a3f98) into master (8791848) will not change coverage.
The diff coverage is 0.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master      #80   +/-   ##
=======================================
  Coverage   14.22%   14.22%           
=======================================
  Files           3        3           
  Lines         253      253           
=======================================
  Hits           36       36           
  Misses        213      213           
  Partials        4        4           
Impacted Files Coverage Δ
downloader/download.go 4.79% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ce32b26...03a3f98. Read the comment docs.

msg = st.Message()

if strings.Contains(cause.Error(), "not found") ||
strings.Contains(cause.Error(), "can't fetch container info") {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

String matching is fragile of course, but still better than current status-quo.

@alexvanin alexvanin merged commit 4d3d80f into nspcc-dev:master Jul 21, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

"400 bad request" is returned for non-existing objects instead of 404
4 participants