[#76] Added HEAD methods #79
Conversation
Codecov Report
@@ Coverage Diff @@
## master #79 +/- ##
==========================================
- Coverage 18.18% 14.22% -3.96%
==========================================
Files 2 3 +1
Lines 198 253 +55
==========================================
Hits 36 36
- Misses 158 213 +55
Partials 4 4
Continue to review full report at Codecov.
|
downloader/download.go
Outdated
| r.SetContentType(contentType) | ||
| } | ||
|
|
||
| func (r *request) handleErr(err error, start time.Time) { |
There was a problem hiding this comment.
I suggest to use more specific name there, e.g. handleAPIErr or handleNeoFSErr. And then we can fix #30 there by parsing error details without grpc.Status.
| d.byAddress(c, request.headObject) | ||
| } | ||
|
|
||
| func (d *Downloader) byAddress(c *fasthttp.RequestCtx, f func(request, client.Object, *object.Address)) { |
There was a problem hiding this comment.
It will be appreciated to see some comments in code about f here and reference it in byAttribute.
Alternatively you can write comments about byAddress function that it prepares input data for f() to process. It will help for other developers to get into it.
Signed-off-by: Denis Kirillov <denis@nspcc.ru>
|
Could you please add some documentation about HEAD methods into the README? |
Signed-off-by: Denis Kirillov <denis@nspcc.ru>
closes #76
Signed-off-by: Denis Kirillov denis@nspcc.ru