refs: add WalletConnect signature type #206
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
realloc
reviewed
Mar 16, 2022
refs/types.proto
Outdated
| @@ -116,6 +116,11 @@ enum SignatureScheme { | |||
|
|
|||
| // Deterministic ECDSA with SHA-256 hashing (RFC 6979) | |||
| ECDSA_RFC6979_SHA256 = 1; | |||
|
|
|||
| // Deterministic ECDSA with SHA-256 hashing using WalletConnect API. | |||
| // Here the algorithm is the same, but the actual format for forming | |||
There was a problem hiding this comment.
Proposed change: but the message format differs.
Signed-off-by: Evgenii Stratonikov <evgeniy@nspcc.ru>
cthulhu-rider
approved these changes
Jun 20, 2022
alexvanin
approved these changes
Jun 20, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I will update the comment when the reference document is there.
Signed-off-by: Evgenii Stratonikov evgeniy@nspcc.ru