-
Notifications
You must be signed in to change notification settings - Fork 15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
object: Add LOCK
type
#196
Merged
cthulhu-rider
merged 8 commits into
nspcc-dev:master
from
cthulhu-rider:194-object-lock-type
Feb 22, 2022
Merged
object: Add LOCK
type
#196
cthulhu-rider
merged 8 commits into
nspcc-dev:master
from
cthulhu-rider:194-object-lock-type
Feb 22, 2022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
cthulhu-rider
commented
Feb 15, 2022
- closes Define LOCK object type #194
I've added documentation of |
3be7f66
to
fab4c7b
Compare
carpawell
reviewed
Feb 16, 2022
realloc
reviewed
Feb 17, 2022
realloc
reviewed
Feb 17, 2022
realloc
approved these changes
Feb 21, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Lets the others also review this.
carpawell
approved these changes
Feb 21, 2022
NeoFS introduces object LOCKs - a mechanism for locking an object from, for example, deletion. Object locks are implemented and stored in the container as objects, so there is a need to define a new type of system objects. Add `LOCK` value to `ObjectType` enum. Signed-off-by: Leonard Lyubich <leonard@nspcc.ru>
Add `status.Object` section for object failures. Add `LOCKED` and `LOCK_NON_REGULAR_OBJECT` codes to it. Return these codes from `Put` and `Delete` RPCs of `ObjectService`. Signed-off-by: Leonard Lyubich <leonard@nspcc.ru>
Define `object.Lock` message which carries list of locked objects. Require this message to be a payload of locked objects (`LOCK` type). Signed-off-by: Leonard Lyubich <leonard@nspcc.ru>
Signed-off-by: Stanislav Bogatyrev <stanislav@nspcc.ru>
…ce RPCs Signed-off-by: Leonard Lyubich <leonard@nspcc.ru>
…etail Signed-off-by: Leonard Lyubich <leonard@nspcc.ru>
Add `OBJECT_ALREADY_REMOVED` value to `Object` enumeration. Return this status from object GET/HEAD/RANGE operations. Signed-off-by: Leonard Lyubich <leonard@nspcc.ru>
39696a5
to
b55fa44
Compare
realloc
approved these changes
Feb 21, 2022
fyrchik
approved these changes
Feb 22, 2022
Signed-off-by: Leonard Lyubich <leonard@nspcc.ru>
b55fa44
to
71a75c7
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.