Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add spacing 2.5 #1513

Merged
merged 3 commits into from
Feb 20, 2025
Merged

Add spacing 2.5 #1513

merged 3 commits into from
Feb 20, 2025

Conversation

IngridGomo
Copy link
Contributor

@IngridGomo IngridGomo commented Feb 19, 2025

Background

Needed to add spacing 2.5 to be able to use 15px in app.

Solution

Added spacing 2.5 to spacing.ts.

Chakra update checklist

  • Updated Sanity documentation in v2 dataset (English, links, component props and content)
  • Updated documentation in the component file
  • Update green-beans-check.md with any major changes
  • Add changeset
  • Double check design in Figma

UU checks

  • It is possible to use the keyboard to reach your changes
  • It is possible to enlarge the text 400% without losing functionality
  • It works on both mobile and desktop
  • It works in both Chrome, Safari and Firefox
  • It works with VoiceOver
  • There are no errors in aXe / SiteImprove-plugins / Wave
  • Sanity documentation has been / will be updated (if neccessary)

If no packages, only docs has been changed:

  • Documentation version has been bumped (package.json in docs)

Everything about making a React component:
https://spor.vy.no/guides/how-to-make-new-react-components

HOW TO MAKE A CHANGESET:
Go here: https://spor.vy.no/guides/how-to-make-new-react-components#creating-a-pr-and-publish-package

@IngridGomo IngridGomo requested review from ithen15 and a team as code owners February 19, 2025 14:02
@IngridGomo IngridGomo requested review from Cmoen11, leiferikbjorkli, cibietici, hunshamar, alicemacl, mtdyrli and mcklien and removed request for a team February 19, 2025 14:02
Copy link

changeset-bot bot commented Feb 19, 2025

🦋 Changeset detected

Latest commit: 3d3ce96

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 2 packages
Name Type
@vygruppen/spor-design-tokens Minor
@vygruppen/spor-react Minor

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@alicemacl
Copy link
Contributor

@IngridGomo
Copy link
Contributor Author

Mangler changeset https://spor.vy.no/guides/how-to-make-new-react-components#creating-a-pr-and-publish-package

Takk! Jeg har aldri endret noe i Spor før, så jeg prøver meg litt frem her. Veldig gjerne si i fra om jeg mangler noe mer/har gjort noe feil/skal pushe flere eller færre filer 😄

Copy link
Contributor

@alicemacl alicemacl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Bra! En liten ting til

Copy link
Contributor

@alicemacl alicemacl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Bra! Bare å kjøre ut denne

@IngridGomo IngridGomo merged commit 2453bf1 into main Feb 20, 2025
2 checks passed
@IngridGomo IngridGomo deleted the add-spacing-2.5 branch February 20, 2025 09:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants