Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(core): add sync generators option to target defaults in nx-schema #29441

Merged
merged 1 commit into from
Feb 3, 2025

Conversation

amrsalama
Copy link
Contributor

Current Behavior

The JSON schema oftargetDefaults in nx.json doesn't accept syncGenerators even though it can be defined and NX respects it.

Expected Behavior

To be able to define default syncGenerators for targets in nx.json without schema violations.

@amrsalama amrsalama requested a review from a team as a code owner December 20, 2024 07:19
@amrsalama amrsalama requested a review from Cammisuli December 20, 2024 07:19
Copy link

vercel bot commented Dec 20, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Skipped Deployment
Name Status Preview Updated (UTC)
nx-dev ⬜️ Ignored (Inspect) Visit Preview Feb 3, 2025 2:16pm

Copy link

nx-cloud bot commented Dec 20, 2024

View your CI Pipeline Execution ↗ for commit 9898db5.

Command Status Duration Result
nx affected --targets=lint,test,build,e2e,e2e-c... ✅ Succeeded 40m 14s View ↗
nx run-many -t check-imports check-commit check... ✅ Succeeded 15s View ↗
nx-cloud record -- nx-cloud conformance:check ✅ Succeeded 2s View ↗
nx-cloud record -- nx format:check --base= --he... ✅ Succeeded 5s View ↗
nx-cloud record -- nx sync:check ✅ Succeeded 4s View ↗
nx documentation ✅ Succeeded 2m 48s View ↗

☁️ Nx Cloud last updated this comment at 2025-02-03 15:03:52 UTC

@MaxKless MaxKless merged commit bc06d63 into nrwl:master Feb 3, 2025
12 checks passed
FrozenPandaz pushed a commit that referenced this pull request Feb 6, 2025
FrozenPandaz pushed a commit that referenced this pull request Feb 6, 2025
Copy link

github-actions bot commented Feb 9, 2025

This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 9, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants