use cobra for notation cli #255
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: zaihaoyin <zaihaoyin@microsoft.com>
qweeah
reviewed
Jul 20, 2022
added 2 commits
July 21, 2022 10:06
Signed-off-by: zaihaoyin <zaihaoyin@microsoft.com>
binbin-li
reviewed
Jul 21, 2022
binbin-li
reviewed
Jul 21, 2022
Signed-off-by: zaihaoyin <zaihaoyin@microsoft.com>
Signed-off-by: zaihaoyin <zaihaoyin@microsoft.com>
|
LGTM |
|
@gokarnm - can you or someone on your side please review this today? This is important/blocking to move forward for a number of things, including bug fixes we have. |
|
lgtm |
shizhMSFT
reviewed
Jul 27, 2022
Signed-off-by: zaihaoyin <zaihaoyin@microsoft.com>
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: zaihaoyin zaihaoyin@microsoft.com
What
This PR fixes #183 by using
github.com/spf13/cobrato replace github.com/urfave/cli/v2, which is a cli package also used by oras-cli.This PR also fixed #211, which is caused by
urfave.Notice
According to the statement from previous PR(#250), this is the second PR of the whole series, which updates
cmd/notation.As we have discussed in the #251,
docker-notationmay be moved to another repo, so I will left most of the code unchanged.Though, I changed
signImagefunction of thedocker-notationcmd only to make sure the code can be compiled.I will add unit test in the next PR.