chore(license): add copyright #267
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Pritesh Bandi <pritesb@amazon.com>
Signed-off-by: Pritesh Bandi <pritesb@amazon.com>
priteshbandi
requested review from
FeynmanZhou,
iamsamirzon,
sajayantony,
shizhMSFT,
toddysm and
vaninrao10
iamsamirzon
reviewed
Feb 3, 2023
| @@ -186,7 +186,7 @@ | |||
| same "printed page" as the copyright notice for easier | |||
| identification within third-party archives. | |||
|
|
|||
| Copyright [yyyy] [name of copyright owner] | |||
| Copyright 2020 The Notation Authors | |||
There was a problem hiding this comment.
Should it be 2019-2023 The Notary v2 and Notation Authors
There was a problem hiding this comment.
+1 to @iamsamirzon proposal
There was a problem hiding this comment.
To keep this copyright simple and reusable in all Notary repos, I think 2019-2023 The Notary Authors is appropriate since Notary is the project org/branding name.
priteshbandi
changed the title
toddysm
requested changes
Feb 3, 2023
| @@ -186,7 +186,7 @@ | |||
| same "printed page" as the copyright notice for easier | |||
| identification within third-party archives. | |||
|
|
|||
| Copyright [yyyy] [name of copyright owner] | |||
| Copyright 2020 The Notation Authors | |||
There was a problem hiding this comment.
+1 to @iamsamirzon proposal
shizhMSFT
changed the title
|
Closing PR as per community discussion; (other CNCF graduated projects still have |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
update License: Added copyright
References:
Signed-off-by: Pritesh Bandi pritesb@amazon.com