Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Don't show the download button if we are not connected to an online n… #1939

Merged
merged 1 commit into from
Feb 7, 2024
Merged

Don't show the download button if we are not connected to an online n… #1939

merged 1 commit into from
Feb 7, 2024

Conversation

manyoso
Copy link
Collaborator

@manyoso manyoso commented Feb 7, 2024

…etwork.

Describe your changes

Issue ticket number and link

Checklist before requesting a review

  • I have performed a self-review of my code.
  • If it is a core feature, I have added thorough tests.
  • I have added thorough documentation for my code.
  • I have tagged PR with relevant project labels. I acknowledge that a PR without labels may be dismissed.
  • If this PR addresses a bug, I have provided both a screenshot/video of the original bug and the working solution.

Demo

Steps to Reproduce

Notes

@manyoso
Don't show the download button if we are not connected to an online n…
ca1f8b8 
…etwork.

Signed-off-by: Adam Treat <treat.adam@gmail.com>
@manyoso manyoso requested a review from cebtenzzre February 7, 2024 14:55
@manyoso manyoso mentioned this pull request Feb 7, 2024
Open
cebtenzzre
cebtenzzre approved these changes Feb 7, 2024
View reviewed changes
Copy link
Member

@cebtenzzre cebtenzzre left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a nice solution.

@manyoso manyoso merged commit 260a56c into main Feb 7, 2024
6 of 10 checks passed
@cebtenzzre cebtenzzre deleted the network_check branch February 10, 2025 16:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cebtenzzre cebtenzzre cebtenzzre approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@manyoso @cebtenzzre