feat(experimental): Issue missing case error for match expressions #7560
Conversation
Co-authored-by: Maxim Vezenov <mvezenov@gmail.com>
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
There was a problem hiding this comment.
⚠️ Performance Alert ⚠️
Possible performance regression was detected for benchmark 'Compilation Time'.
Benchmark result of this commit is worse than the previous benchmark result exceeding threshold 1.20.
| Benchmark suite | Current: b3ed7d7 | Previous: 223656f | Ratio |
|---|---|---|---|
ram_blowup_regression |
20.7 s |
14.9 s |
1.39 |
This comment was automatically generated by workflow using github-action-benchmark.
CC: @TomAFrench
There was a problem hiding this comment.
⚠️ Performance Alert ⚠️
Possible performance regression was detected for benchmark 'Compilation Memory'.
Benchmark result of this commit is worse than the previous benchmark result exceeding threshold 1.20.
| Benchmark suite | Current: b3ed7d7 | Previous: 223656f | Ratio |
|---|---|---|---|
rollup-block-root-empty |
365.29 MB |
302.97 MB |
1.21 |
rollup-merge |
363.71 MB |
301.39 MB |
1.21 |
This comment was automatically generated by workflow using github-action-benchmark.
CC: @TomAFrench
There was a problem hiding this comment.
⚠️ Performance Alert ⚠️
Possible performance regression was detected for benchmark 'Execution Memory'.
Benchmark result of this commit is worse than the previous benchmark result exceeding threshold 1.20.
| Benchmark suite | Current: b3ed7d7 | Previous: 223656f | Ratio |
|---|---|---|---|
rollup-merge |
348.27 MB |
289.87 MB |
1.20 |
This comment was automatically generated by workflow using github-action-benchmark.
CC: @TomAFrench
Description
Problem*
Resolves
Summary*
Issues a missing case(s) error for match expressions missing any cases. This includes constructing an example of a value which fails to match.
Additional Context
Limitation: if the match doesn't match on any cases such asThis has been implemented along with ranges for integers (see tests).match foo {}we don't issue a helpful error likeMissing cases Foo, Bar, Bazand instead issueMissing cases: _. This could be fixed but it is the end of the week so I wanted to get this work out.Documentation*
Check one:
PR Checklist*
cargo fmton default settings.