Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore!: rename verify_proof to delayed_proof_aggregation #3842

Closed
wants to merge 1 commit into from

Conversation

kevaundray
Copy link
Contributor

Description

This is a naming suggestion for std::verify_proof to make it clearer that it is not verifying a proof in the circuit.

Problem*

Resolves

Summary*

Additional Context

Documentation*

Check one:

  • No documentation needed.
  • Documentation included in this PR.
  • [Exceptional Case] Documentation to be submitted in a separate PR.

PR Checklist*

  • I have tested the changes locally.
  • I have formatted the changes with Prettier and/or cargo fmt on default settings.

@kevaundray kevaundray changed the title chore: rename verify_proof to delayed_proof_aggregation chore!: rename verify_proof to delayed_proof_aggregation Dec 16, 2023
@kevaundray
Copy link
Contributor Author

I don't particularly think that delayed_proof_aggregation is the best name here either. Perhaps delayed_proof_verification ?

This is blocked by AztecProtocol/aztec-packages#3528 just due to them both changing recursion interface

@vezenovm
Copy link
Contributor

I don't particularly think that delayed_proof_aggregation is the best name here either. Perhaps delayed_proof_verification ?

What about just proof_aggregation?

@TomAFrench
Copy link
Member

aggregate_proof would be be preferable to proof_aggregation

@TomAFrench TomAFrench closed this Jul 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants