nexclout: make app enable/disable task idempotent

ref. nextcloud/server#19514 ref. nextcloud/server#17789
nodiscc · Jun 1, 2020 · 10443a4 · 10443a4
1 parent df6df7f
commit 10443a4
Showing 1 changed file with 3 additions and 2 deletions.
diff --git a/roles/nextcloud/tasks/nextcloud.yml b/roles/nextcloud/tasks/nextcloud.yml
@@ -258,7 +258,6 @@
   register: nextcloud_upgrade
   changed_when: not 'Nextcloud is already latest version' in nextcloud_upgrade.stdout
 
-# Not idempotent - https://github.com/nextcloud/server/issues/17789
 - name: enable/disable nextcloud applications
   become: yes
   become_user: www-data
@@ -267,4 +266,6 @@
     chdir: "{{ nextcloud_install_dir }}"
   with_items: "{{ nextcloud_apps }}"
   register: nextcloud_app_enable_disable
-  changed_when: not 'No such app enabled' in nextcloud_app_enable_disable.stdout
+  changed_when:
+    - not 'No such app enabled' in nextcloud_app_enable_disable.stdout
+    - not 'already enabled' in nextcloud_app_enable_disable.stdout