Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

TypeError on empty action #528

Merged
merged 1 commit into from
Jan 7, 2021
Merged

TypeError on empty action #528

merged 1 commit into from
Jan 7, 2021

Conversation

aalykiot
Copy link
Member

@aalykiot aalykiot commented Jan 7, 2021

Throwing a TypeError if the action parameter is not provided. #524

@aalykiot aalykiot requested review from lance and helio-frota January 7, 2021 09:55
@aalykiot aalykiot changed the title Type-error on empty action TypeError on empty action Jan 7, 2021
helio-frota
helio-frota approved these changes Jan 7, 2021
View reviewed changes
Copy link
Member

@helio-frota helio-frota left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@lholmquist lholmquist merged commit 7b51dba into master Jan 7, 2021
@lholmquist lholmquist deleted the action-parameter branch January 7, 2021 15:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lholmquist lholmquist lholmquist approved these changes

@helio-frota helio-frota helio-frota approved these changes

@lance lance Awaiting requested review from lance

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@aalykiot @lholmquist @helio-frota