-
Notifications
You must be signed in to change notification settings - Fork 59
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add local_build.sh script and instructions for local/dev use #108
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I recommend building and running the container(s) with the same uid and gid as the host user otherwise you can end up with mismatched owner/permissions in the mounted volumes after the build(s) completes.
7356cf0
to
626bafe
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The update works great but the variable needs to be passed to the other two docker commands. I was able to successfully local_build my branch after making the changes below
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!! 🚀
About time this got done, mainly useful for people contributing new recipes, so they can actually test them locally (and we can too).