Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(engines): Define proper node version #3920

Closed
wants to merge 1 commit into from

Conversation

rozzilla
Copy link

@rozzilla rozzilla commented Dec 3, 2024

This relates to...

When installing the last undici version (v7.0.0) on node version 20.18.1:

node:internal/modules/cjs/loader:1225
  const err = new Error(message);
              ^

Error: Cannot find module 'node:sqlite'

Rationale

The node version defined in the engines of the package.json should be updated, considering that the brand new SQLite version is available only on node >= 22.x

Changes

Updated the package.json

Features

N/A

Bug Fixes

N/A

Breaking Changes and Deprecations

I think we should communicate that undici version 7 will NOT work on node version 20.x

Status

@mcollina
Copy link
Member

mcollina commented Dec 3, 2024

This loads correctly on Node.js v20, so maybe you have something odd in your setup.

@rozzilla
Copy link
Author

rozzilla commented Dec 3, 2024

I confirm this is now fixed by version 7.1.0

@rozzilla rozzilla closed this Dec 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants