Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove call to deprecated function util.inherits #4483

Merged
merged 4 commits into from
Apr 24, 2022
Merged

Conversation

louwers
Copy link
Contributor

@louwers louwers commented Mar 13, 2022

Affected URL(s)

https://nodejs.org/en/docs/guides/event-loop-timers-and-nexttick

Description of the problem

On the bottom of this help page, util.inherits is used.

This function is deprecated. I think the docs should set an example and not use deprecated functionality! The example should be updated with class based syntax.

@Trott Trott enabled auto-merge (squash) March 29, 2022 03:30
@Trott Trott merged commit 84ab100 into nodejs:main Apr 24, 2022
@SEWeiTung
Copy link
Contributor

@nodejs/translators : This file has been updated, please do translations when possible :)

oszwilk added a commit to oszwilk/nodejs.org that referenced this pull request Apr 24, 2022
* Blog: Node.js 18 release announcement

Co-authored-by: Antoine du Hamel <duhamelantoine1995@gmail.com>
Co-authored-by: Ethan Arrowood <ethan@arrowood.dev>
Co-authored-by: Matteo Collina <hello@matteocollina.com>
Co-authored-by: Michael Dawson <mdawson@devrus.com>
Co-authored-by: Michaël Zasso <targos@protonmail.com>
Co-authored-by: Rich Trott <rtrott@gmail.com>
Co-authored-by: Richard Lau <rlau@redhat.com>
Co-authored-by: Joyee Cheung <joyeec9h3@gmail.com>

* Blog: v18.0.0 release post

Refs: nodejs/node#42262

* fix: add Node.js 16.x and 17.x to generated version link list (nodejs#4545)

* fix: add Node.js 16.x and 17.x to generated version link list

`source/nodejsVersions.md` is used to generate a list of version links
on each locale page. Node.js 17.x were missing.

Co-authored-by: Nick Schonning <nschonni@gmail.com>

* zh-CN: update site.json for Node.js 18 (nodejs#4554)

Ref: nodejs#4553

* Fix typo (nodejs#4557)

"to be trust" should be "to trust" as a transitive verb.

* doc: update link about class features optimizations in Node.js 18 (nodejs#4556)

There is a blog post explaining about this now, change the link.

* doc: typo fix (nodejs#4558)

Add missing "to" between the two verbs as a typo fix.

* doc: fix wrong link for "windows" (nodejs#4514)

The anchor to Windows installation session now points to "install nvs on Windows". This PR fixes the anchor to the correct location.

* chore: replace callbacks with necessary async/await (nodejs#4555)

1. Some functions like 'fs' or 'graceFulFs' has been supporting
'async/await' for a long time, so this is a refactor to improve
the related codes.

2. 'sass.render' is deprecated, use awaitable 'sass.compileAsync'
instead.

* Remove call to deprecated function util.inherits (nodejs#4483)

* Remove call to deprecated function util.inherits

* Update event-loop-timers-and-nexttick.md

Co-authored-by: Rich Trott <rtrott@gmail.com>

* Meetup sweden stockholm (nodejs#4407)

Add the meetup for sweden stockholm.

Co-authored-by: Beth Griggs <bgriggs@redhat.com>
Co-authored-by: Antoine du Hamel <duhamelantoine1995@gmail.com>
Co-authored-by: Ethan Arrowood <ethan@arrowood.dev>
Co-authored-by: Matteo Collina <hello@matteocollina.com>
Co-authored-by: Michael Dawson <mdawson@devrus.com>
Co-authored-by: Michaël Zasso <targos@protonmail.com>
Co-authored-by: Rich Trott <rtrott@gmail.com>
Co-authored-by: Richard Lau <rlau@redhat.com>
Co-authored-by: Joyee Cheung <joyeec9h3@gmail.com>
Co-authored-by: Austin Kelleher <austinlkelleher@gmail.com>
Co-authored-by: Nick Schonning <nschonni@gmail.com>
Co-authored-by: Maledong <maledong_public@foxmail.com>
Co-authored-by: Kenny <67985757+protofarer@users.noreply.github.com>
Co-authored-by: Javad <79276645+Javad-93@users.noreply.github.com>
Co-authored-by: Tse Kit Yam <tsekityam@users.noreply.github.com>
Co-authored-by: Bart Louwers <bart.louwers@gmail.com>
Co-authored-by: lxmarinkovic <lxmarinkovic@gmail.com>
SEWeiTung added a commit that referenced this pull request Apr 25, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants