inspector: convert event params to protocol without json #57027
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nodejs-github-bot
added
c++
legendecas
added
the
inspector
legendecas
force-pushed
the
inspector/stringify
branch
2 times, most recently
from
88567de to
2c4f439
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #57027 +/- ##
==========================================
- Coverage 89.11% 89.07% -0.04%
==========================================
Files 665 666 +1
Lines 193193 193282 +89
Branches 37212 37256 +44
==========================================
+ Hits 172158 172167 +9
- Misses 13775 13815 +40
- Partials 7260 7300 +40
|
Event params object can be converted to inspector protocol directly. This also enables binary data, like `Network.dataReceived`, to be sent in the inspector protocol from JavaScript since JSON representation does not support plain binary data.
legendecas
force-pushed
the
inspector/stringify
branch
from
2c4f439 to
cdd0230
Compare
github-actions
bot
removed
the
request-ci
|
@nodejs/inspector would you mind taking a look at this? Thank you! |
|
@nodejs/inspector @nodejs/cpp-reviewers would you mind taking a look at this? Thank you! |
cola119
approved these changes
Feb 24, 2025
legendecas
added
commit-queue
nodejs-github-bot
removed
the
commit-queue
|
Landed in b7beb33 |
targos
pushed a commit
that referenced
this pull request
Feb 25, 2025
Event params object can be converted to inspector protocol directly. This also enables binary data, like `Network.dataReceived`, to be sent in the inspector protocol from JavaScript since JSON representation does not support plain binary data. PR-URL: #57027 Reviewed-By: Kohei Ueno <kohei.ueno119@gmail.com>
targos
pushed a commit
that referenced
this pull request
Feb 25, 2025
Event params object can be converted to inspector protocol directly. This also enables binary data, like `Network.dataReceived`, to be sent in the inspector protocol from JavaScript since JSON representation does not support plain binary data. PR-URL: #57027 Reviewed-By: Kohei Ueno <kohei.ueno119@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Event params object can be converted to inspector protocol directly.
This also enables binary data, like
Network.dataReceived, to be sentin the inspector protocol from JavaScript since JSON representation
does not support plain binary data.