-
Notifications
You must be signed in to change notification settings - Fork 30.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[v20.x backport] doc: add documentation for process.features #56948
Closed
marco-ippolito
wants to merge
2
commits into
nodejs:v20.x-staging
from
marco-ippolito:backports-some-stuff
Closed
[v20.x backport] doc: add documentation for process.features #56948
marco-ippolito
wants to merge
2
commits into
nodejs:v20.x-staging
from
marco-ippolito:backports-some-stuff
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PR-URL: nodejs#54897 Refs: nodejs#54295 Reviewed-By: Ethan Arrowood <ethan@arrowood.dev> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com> Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Chengzhong Wu <legendecas@gmail.com>
Thanks, do you plan to merge it soon? |
Actually I think #54982 should probably also be there, though I can also just rebase on top of a bunch of REPLACEME (but they aren't really supposed to be picked up by the script in this release right?) |
Yeah that commit needs to get backported. I'll land this right after this release. |
PR-URL: nodejs#54982 Refs: nodejs@aa0308d Refs: nodejs@9010f5f Refs: nodejs@52a40e0 Refs: nodejs@b3ef289 Refs: nodejs#2564 Refs: nodejs#25819 Refs: nodejs#27311 Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com> Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
joyeecheung
approved these changes
Feb 10, 2025
Landed in de5cbdc...697a392 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR-URL: #54897
Refs: #54295
Reviewed-By: Ethan Arrowood ethan@arrowood.dev
Reviewed-By: Trivikram Kamat trivikr.dev@gmail.com
Reviewed-By: Antoine du Hamel duhamelantoine1995@gmail.com
Reviewed-By: Chengzhong Wu legendecas@gmail.com
cc @joyeecheung