Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fs: remove fs.F_OK, fs.R_OK, fs.W_OK, fs.X_OK #55862

Conversation

LiviaMedeiros
Copy link
Contributor

Follow-up from: #49686 (runtime deprecation)

@nodejs-github-bot nodejs-github-bot added fs Issues and PRs related to the fs subsystem / file system. needs-ci PRs that need a full CI run. labels Nov 15, 2024
@LiviaMedeiros LiviaMedeiros added semver-major PRs that contain breaking changes and should be released in the next major version. deprecations Issues and PRs related to deprecations. labels Nov 15, 2024
@aduh95 aduh95 added the blocked PRs that are blocked by other issues or PRs. label Nov 15, 2024
@aduh95
Copy link
Contributor

aduh95 commented Nov 15, 2024

Blocked until the v24.x cutoff

Copy link

codecov bot commented Nov 15, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 88.41%. Comparing base (b02cd41) to head (82ee7d8).
Report is 700 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main   #55862      +/-   ##
==========================================
- Coverage   88.42%   88.41%   -0.01%     
==========================================
  Files         654      654              
  Lines      187852   187804      -48     
  Branches    36134    36130       -4     
==========================================
- Hits       166102   166051      -51     
- Misses      14989    14991       +2     
- Partials     6761     6762       +1     
Files with missing lines Coverage Δ
lib/fs.js 98.23% <ø> (-0.03%) ⬇️

... and 15 files with indirect coverage changes

@aduh95 aduh95 added author ready PRs that have at least one approval, no pending requests for changes, and a CI started. request-ci Add this label to start a Jenkins CI on a PR. and removed blocked PRs that are blocked by other issues or PRs. labels Feb 23, 2025
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Feb 23, 2025
@nodejs-github-bot
Copy link
Collaborator

@aduh95 aduh95 added the commit-queue Add this label to land a pull request using GitHub Actions. label Feb 23, 2025
@nodejs-github-bot nodejs-github-bot added commit-queue-failed An error occurred while landing this pull request using GitHub Actions. and removed commit-queue Add this label to land a pull request using GitHub Actions. labels Feb 23, 2025
@nodejs-github-bot
Copy link
Collaborator

Commit Queue failed
- Loading data for nodejs/node/pull/55862
✔  Done loading data for nodejs/node/pull/55862
----------------------------------- PR info ------------------------------------
Title      fs: remove `fs.F_OK`, `fs.R_OK`, `fs.W_OK`, `fs.X_OK` (#55862)
   ⚠  Could not retrieve the email or name of the PR author's from user's GitHub profile!
Branch     LiviaMedeiros:fs-eol-deprecate-moisting-constants -> nodejs:main
Labels     fs, semver-major, author ready, deprecations, needs-ci
Commits    2
 - fs: remove `fs.F_OK`, `fs.R_OK`, `fs.W_OK`, `fs.X_OK`
 - squash: fill PR number
Committers 1
 - LiviaMedeiros <livia@cirno.name>
PR-URL: https://github.com/nodejs/node/pull/55862
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
------------------------------ Generated metadata ------------------------------
PR-URL: https://github.com/nodejs/node/pull/55862
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
--------------------------------------------------------------------------------
   ℹ  This PR was created on Fri, 15 Nov 2024 08:18:34 GMT
   ✔  Approvals: 2
   ✔  - James M Snell (@jasnell) (TSC): https://github.com/nodejs/node/pull/55862#pullrequestreview-2456430375
   ✔  - Antoine du Hamel (@aduh95) (TSC): https://github.com/nodejs/node/pull/55862#pullrequestreview-2635359525
   ✔  Last GitHub CI successful
   ℹ  Last Full PR CI on 2025-02-23T00:21:49Z: https://ci.nodejs.org/job/node-test-pull-request/65379/
- Querying data for job/node-test-pull-request/65379/
   ✔  Last Jenkins CI successful
--------------------------------------------------------------------------------
   ✔  No git cherry-pick in progress
   ✔  No git am in progress
   ✔  No git rebase in progress
--------------------------------------------------------------------------------
- Bringing origin/main up to date...
From https://github.com/nodejs/node
 * branch                  main       -> FETCH_HEAD
✔  origin/main is now up-to-date
- Downloading patch for 55862
From https://github.com/nodejs/node
 * branch                  refs/pull/55862/merge -> FETCH_HEAD
✔  Fetched commits as e2bc395c4206..82ee7d80a731
--------------------------------------------------------------------------------
Auto-merging doc/api/deprecations.md
Auto-merging doc/api/fs.md
Auto-merging lib/fs.js
[main 15b2ff1a63] fs: remove `fs.F_OK`, `fs.R_OK`, `fs.W_OK`, `fs.X_OK`
 Author: LiviaMedeiros <livia@cirno.name>
 Date: Fri Nov 15 16:09:08 2024 +0800
 4 files changed, 11 insertions(+), 71 deletions(-)
Auto-merging doc/api/deprecations.md
Auto-merging doc/api/fs.md
[main 91c363bed6] squash: fill PR number
 Author: LiviaMedeiros <livia@cirno.name>
 Date: Fri Nov 15 16:20:09 2024 +0800
 2 files changed, 2 insertions(+), 2 deletions(-)
   ✔  Patches applied
There are 2 commits in the PR. Attempting autorebase.
Rebasing (2/4)
Executing: git node land --amend --yes
--------------------------------- New Message ----------------------------------
fs: remove `fs.F_OK`, `fs.R_OK`, `fs.W_OK`, `fs.X_OK`

PR-URL: #55862
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>

[detached HEAD 3d8f7a4b9c] fs: remove fs.F_OK, fs.R_OK, fs.W_OK, fs.X_OK
Author: LiviaMedeiros <livia@cirno.name>
Date: Fri Nov 15 16:09:08 2024 +0800
4 files changed, 11 insertions(+), 71 deletions(-)
Rebasing (3/4)
Rebasing (4/4)
Executing: git node land --amend --yes
--------------------------------- New Message ----------------------------------
squash: fill PR number

PR-URL: #55862
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>

[detached HEAD 7eac1acc3e] squash: fill PR number
Author: LiviaMedeiros <livia@cirno.name>
Date: Fri Nov 15 16:20:09 2024 +0800
2 files changed, 2 insertions(+), 2 deletions(-)
Successfully rebased and updated refs/heads/main.

ℹ Add commit-queue-squash label to land the PR as one commit, or commit-queue-rebase to land as separate commits.

https://github.com/nodejs/node/actions/runs/13481710299

@aduh95 aduh95 added commit-queue Add this label to land a pull request using GitHub Actions. commit-queue-squash Add this label to instruct the Commit Queue to squash all the PR commits into the first one. and removed commit-queue-failed An error occurred while landing this pull request using GitHub Actions. labels Feb 23, 2025
@nodejs-github-bot nodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Feb 23, 2025
@nodejs-github-bot nodejs-github-bot merged commit 25dd206 into nodejs:main Feb 23, 2025
87 checks passed
@nodejs-github-bot
Copy link
Collaborator

Landed in 25dd206

acidiney pushed a commit to acidiney/node that referenced this pull request Feb 23, 2025
PR-URL: nodejs#55862
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. commit-queue-squash Add this label to instruct the Commit Queue to squash all the PR commits into the first one. deprecations Issues and PRs related to deprecations. fs Issues and PRs related to the fs subsystem / file system. needs-ci PRs that need a full CI run. semver-major PRs that contain breaking changes and should be released in the next major version.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants