-
Notifications
You must be signed in to change notification settings - Fork 30.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fs: remove fs.F_OK
, fs.R_OK
, fs.W_OK
, fs.X_OK
#55862
fs: remove fs.F_OK
, fs.R_OK
, fs.W_OK
, fs.X_OK
#55862
Conversation
Blocked until the v24.x cutoff |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #55862 +/- ##
==========================================
- Coverage 88.42% 88.41% -0.01%
==========================================
Files 654 654
Lines 187852 187804 -48
Branches 36134 36130 -4
==========================================
- Hits 166102 166051 -51
- Misses 14989 14991 +2
- Partials 6761 6762 +1
|
Commit Queue failed- Loading data for nodejs/node/pull/55862 ✔ Done loading data for nodejs/node/pull/55862 ----------------------------------- PR info ------------------------------------ Title fs: remove `fs.F_OK`, `fs.R_OK`, `fs.W_OK`, `fs.X_OK` (#55862) ⚠ Could not retrieve the email or name of the PR author's from user's GitHub profile! Branch LiviaMedeiros:fs-eol-deprecate-moisting-constants -> nodejs:main Labels fs, semver-major, author ready, deprecations, needs-ci Commits 2 - fs: remove `fs.F_OK`, `fs.R_OK`, `fs.W_OK`, `fs.X_OK` - squash: fill PR number Committers 1 - LiviaMedeiros <livia@cirno.name> PR-URL: https://github.com/nodejs/node/pull/55862 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> ------------------------------ Generated metadata ------------------------------ PR-URL: https://github.com/nodejs/node/pull/55862 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> -------------------------------------------------------------------------------- ℹ This PR was created on Fri, 15 Nov 2024 08:18:34 GMT ✔ Approvals: 2 ✔ - James M Snell (@jasnell) (TSC): https://github.com/nodejs/node/pull/55862#pullrequestreview-2456430375 ✔ - Antoine du Hamel (@aduh95) (TSC): https://github.com/nodejs/node/pull/55862#pullrequestreview-2635359525 ✔ Last GitHub CI successful ℹ Last Full PR CI on 2025-02-23T00:21:49Z: https://ci.nodejs.org/job/node-test-pull-request/65379/ - Querying data for job/node-test-pull-request/65379/ ✔ Last Jenkins CI successful -------------------------------------------------------------------------------- ✔ No git cherry-pick in progress ✔ No git am in progress ✔ No git rebase in progress -------------------------------------------------------------------------------- - Bringing origin/main up to date... From https://github.com/nodejs/node * branch main -> FETCH_HEAD ✔ origin/main is now up-to-date - Downloading patch for 55862 From https://github.com/nodejs/node * branch refs/pull/55862/merge -> FETCH_HEAD ✔ Fetched commits as e2bc395c4206..82ee7d80a731 -------------------------------------------------------------------------------- Auto-merging doc/api/deprecations.md Auto-merging doc/api/fs.md Auto-merging lib/fs.js [main 15b2ff1a63] fs: remove `fs.F_OK`, `fs.R_OK`, `fs.W_OK`, `fs.X_OK` Author: LiviaMedeiros <livia@cirno.name> Date: Fri Nov 15 16:09:08 2024 +0800 4 files changed, 11 insertions(+), 71 deletions(-) Auto-merging doc/api/deprecations.md Auto-merging doc/api/fs.md [main 91c363bed6] squash: fill PR number Author: LiviaMedeiros <livia@cirno.name> Date: Fri Nov 15 16:20:09 2024 +0800 2 files changed, 2 insertions(+), 2 deletions(-) ✔ Patches applied There are 2 commits in the PR. Attempting autorebase. Rebasing (2/4) Executing: git node land --amend --yes --------------------------------- New Message ---------------------------------- fs: remove `fs.F_OK`, `fs.R_OK`, `fs.W_OK`, `fs.X_OK`https://github.com/nodejs/node/actions/runs/13481710299 |
Landed in 25dd206 |
PR-URL: nodejs#55862 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Follow-up from: #49686 (runtime deprecation)