doc: enforce strict policy to semver-major releases #55732

RafaelGSS · 2024-11-05T19:02:41Z

This needs to be discussed first by the @nodejs/releasers. However, since the next session (nodejs/TSC#1648) might not happen due to NodeConf/Collab Summit I thought would be better to discuss it async.

cc: @nodejs/releasers @BethGriggs

nodejs-github-bot · 2024-11-05T19:02:46Z

Review requested:

@nodejs/tsc

github-actions · 2024-11-05T19:07:57Z

The notable-change PRs with changes that should be highlighted in changelogs. label has been added by @RafaelGSS.

Please suggest a text for the release notes if you'd like to include a more detailed summary, then proceed to update the PR description with the text or a link to the notable change suggested text comment. Otherwise, the commit will be placed in the Other Notable Changes section.

RafaelGSS · 2024-11-05T19:11:50Z

Adding blocked label to make sure we will land it only when we get releasers consensus.

aduh95

As is, it's wrong to say this PR enforces the strict policy, the commit message is a bit misleading. You could say "clarify", or maybe "stiffen".

IMO, this should either go in the collaborator-guibe.md document (if we expect non-releasers to comply with that policy), and/or the collaborator guide should forbid non-releasers to land semver-major PRs (I don't think we want to do that). If we want the policy to be enforced, the CQ should probably be updated to skip semver-major PRs until the branch-off.

RafaelGSS · 2024-11-05T20:49:30Z

I think landing a semver-major PR on main days/weeks before the semver-major release is ok. It doesn't mean that the commit will be included in the major release. My goal with this doc change is to clarify/enforce that the last sync between main and vN.x will be a month prior to the release. I might be using the wrong word, but I do think "enforce" should mean we won't include any semver-major PR that was merged into main less than a month of the release date (except in specific situations as mentioned in the doc too)

doc/contributing/releases.md

ShogunPanda

LGTM!

mcollina

lgtm

doc/contributing/releases.md

marco-ippolito · 2024-11-06T16:14:20Z

doc/contributing/releases.md

-The TSC should be informed of any `SEMVER-MAJOR` commits that land within one
-month of the release.
+If a `SEMVER-MAJOR` pull requests lands on the default branch within one month prior to
+the major release date, it must not be included on the new major staging branch, unless there is consensus from the Node.js releasers


Maybe adding baking-for-lts label helps releasing it by mistake?

I think that will cause confusion -- that label is for LTS releases and not all semver majors become LTS.

we can add a label so when preparing a release it can be filtered, Its pretty hard to remember otherwise

We don't need to remember if we sync a month earlier as it will be equal to main.

Co-authored-by: Antoine du Hamel <duhamelantoine1995@gmail.com>

RafaelGSS · 2024-11-07T13:16:42Z

PTAL @nodejs/releasers

RafaelGSS · 2024-11-07T15:04:07Z

Adding commit-queue as the majority of nodejs/releasers already approved.

nodejs-github-bot · 2024-11-07T19:08:57Z

Landed in 5ddde04

Co-authored-by: Antoine du Hamel <duhamelantoine1995@gmail.com> PR-URL: #55732 Refs: nodejs/Release#1054 Reviewed-By: Paolo Insogna <paolo@cowtech.it> Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Ulises Gascón <ulisesgascongonzalez@gmail.com> Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com> Reviewed-By: Richard Lau <rlau@redhat.com>