Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

module: add application/json to accept header when fetching json module #50119

Merged
merged 4 commits into from
Oct 30, 2023
Merged

module: add application/json to accept header when fetching json module #50119

merged 4 commits into from
Oct 30, 2023

Conversation

marco-ippolito
Copy link
Member

Refs: #50116

@nodejs-github-bot
Copy link
Collaborator

nodejs-github-bot commented Oct 10, 2023 •
edited by marco-ippolito
Loading

Review requested:

  • @nodejs/loaders

@nodejs-github-bot nodejs-github-bot added esm Issues and PRs related to the ECMAScript Modules implementation. needs-ci PRs that need a full CI run. tools Issues and PRs related to the tools directory. labels Oct 10, 2023
@marco-ippolito marco-ippolito force-pushed the feat/accept branch 2 times, most recently from 2d22e69 to af0919f Compare October 10, 2023 10:52
@marco-ippolito marco-ippolito added the wip Issues and PRs that are still a work in progress. label Oct 10, 2023
@marco-ippolito marco-ippolito force-pushed the feat/accept branch 4 times, most recently from cca1ab5 to ee25f49 Compare October 10, 2023 12:31
@marco-ippolito marco-ippolito removed the wip Issues and PRs that are still a work in progress. label Oct 10, 2023
@aduh95
Copy link
Contributor

aduh95 commented Oct 10, 2023

We should probably wait for whatwg/html#9486 to be merged, right?

@nicolo-ribaudo nicolo-ribaudo mentioned this pull request Oct 11, 2023
Closed
@marco-ippolito
Copy link
Member Author

marco-ippolito commented Oct 12, 2023 •
edited
Loading

blocked by #50140

@marco-ippolito marco-ippolito assigned aduh95 and unassigned aduh95 Oct 14, 2023
@marco-ippolito marco-ippolito requested a review from aduh95 October 14, 2023 08:11
JakobJingleheimer
JakobJingleheimer approved these changes Oct 18, 2023
View reviewed changes
Copy link
Member

@JakobJingleheimer JakobJingleheimer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🙌

Is Antoine's comment still valid? #50119 (comment)

@marco-ippolito
Copy link
Member Author

I guess its ok to wait, but it wouldnt have any backdraw if we merged

@nicolo-ribaudo
Copy link
Contributor

The spec has been merged.

@marco-ippolito marco-ippolito added the request-ci Add this label to start a Jenkins CI on a PR. label Oct 30, 2023
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Oct 30, 2023
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/55328/

@marco-ippolito marco-ippolito added commit-queue Add this label to land a pull request using GitHub Actions. commit-queue-squash Add this label to instruct the Commit Queue to squash all the PR commits into the first one. and removed needs-ci PRs that need a full CI run. labels Oct 30, 2023
@nodejs-github-bot nodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Oct 30, 2023
@nodejs-github-bot nodejs-github-bot merged commit 8d40818 into nodejs:main Oct 30, 2023
@nodejs-github-bot
Copy link
Collaborator

Landed in 8d40818

alexfernandez pushed a commit to alexfernandez/node that referenced this pull request Nov 1, 2023
@marco-ippolito @alexfernandez
module: add application/json in accept header when fetching json module
e3b032c 
PR-URL: nodejs#50119
Refs: nodejs#50116
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Jacob Smith <jacob@frende.me>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
targos pushed a commit that referenced this pull request Nov 11, 2023
@marco-ippolito @targos
module: add application/json in accept header when fetching json module
66d793d 
PR-URL: #50119
Refs: #50116
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Jacob Smith <jacob@frende.me>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
@targos targos mentioned this pull request Nov 12, 2023
Merged
targos pushed a commit that referenced this pull request Nov 14, 2023
@marco-ippolito @targos
module: add application/json in accept header when fetching json module
667d245 
PR-URL: #50119
Refs: #50116
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Jacob Smith <jacob@frende.me>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
UlisesGascon pushed a commit that referenced this pull request Dec 11, 2023
@marco-ippolito @UlisesGascon
module: add application/json in accept header when fetching json module
fffc495 
PR-URL: #50119
Refs: #50116
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Jacob Smith <jacob@frende.me>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
@UlisesGascon UlisesGascon mentioned this pull request Dec 12, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@benjamingr benjamingr benjamingr approved these changes

@JakobJingleheimer JakobJingleheimer JakobJingleheimer approved these changes

@aduh95 aduh95 aduh95 approved these changes

@jasnell jasnell Awaiting requested review from jasnell

Assignees
No one assigned
Labels
commit-queue-squash Add this label to instruct the Commit Queue to squash all the PR commits into the first one. esm Issues and PRs related to the ECMAScript Modules implementation. tools Issues and PRs related to the tools directory.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@marco-ippolito @nodejs-github-bot @aduh95 @nicolo-ribaudo @jasnell @benjamingr @JakobJingleheimer