Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[v16.x] src: split property helpers from node::Environment #44542

Closed
wants to merge 1 commit into from
Closed

[v16.x] src: split property helpers from node::Environment #44542

wants to merge 1 commit into from

Conversation

legendecas
Copy link
Member

PR-URL: #44056
Refs: #42528
Reviewed-By: Ben Noordhuis info@bnoordhuis.nl
Reviewed-By: Matteo Collina matteo.collina@gmail.com
Reviewed-By: Joyee Cheung joyeec9h3@gmail.com
Reviewed-By: Feng Yu F3n67u@outlook.com

@nodejs-github-bot
Copy link
Collaborator

Review requested:

  • @nodejs/crypto
  • @nodejs/modules
  • @nodejs/net
  • @nodejs/startup
  • @nodejs/vm

@nodejs-github-bot nodejs-github-bot added c++ Issues and PRs that require attention from people who are familiar with C++. lib / src Issues and PRs related to general changes in the lib or src directory. needs-ci PRs that need a full CI run. v16.x labels Sep 6, 2022
@legendecas legendecas mentioned this pull request Sep 6, 2022
Closed
@nodejs-github-bot

This comment was marked as outdated.

Sign in to view
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/46622/

@targos targos mentioned this pull request Sep 16, 2022
Merged
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/46668/

@juanarbol juanarbol force-pushed the v16.x-staging branch 4 times, most recently from 02cd9a9 to 54b9635 Compare October 10, 2022 23:49
@legendecas legendecas force-pushed the backport-44056-to-16 branch from 3b9a46b to c3c83eb Compare October 31, 2022 16:57
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/47600/

@legendecas
Copy link
Member Author

Rebased on the latest v16.x-staging.

@legendecas
src: split property helpers from node::Environment
ea74cbf 
PR-URL: nodejs#44056
Refs: nodejs#42528
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
Reviewed-By: Feng Yu <F3n67u@outlook.com>
@legendecas legendecas force-pushed the backport-44056-to-16 branch from c3c83eb to ea74cbf Compare November 8, 2022 16:22
@richardlau richardlau added the request-ci Add this label to start a Jenkins CI on a PR. label Nov 23, 2022
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Nov 23, 2022
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/48138/

@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/48147/

@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/48151/

@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/48153/

richardlau pushed a commit that referenced this pull request Nov 24, 2022
@legendecas @richardlau
src: split property helpers from node::Environment
54608d8 
PR-URL: #44056
Backport-PR-URL: #44542
Refs: #42528
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
Reviewed-By: Feng Yu <F3n67u@outlook.com>
@richardlau
Copy link
Member

Landed in 54608d8.

@richardlau richardlau closed this Nov 24, 2022
@legendecas legendecas deleted the backport-44056-to-16 branch November 24, 2022 16:40
This was referenced Nov 25, 2022
Open
Open
Open
Open
Open
Open
guangwong pushed a commit to noslate-project/node that referenced this pull request Jan 3, 2023
@legendecas @guangwong
src: split property helpers from node::Environment
535c00b 
PR-URL: nodejs/node#44056
Backport-PR-URL: nodejs/node#44542
Refs: nodejs/node#42528
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
Reviewed-By: Feng Yu <F3n67u@outlook.com>
guangwong pushed a commit to noslate-project/node that referenced this pull request Jan 3, 2023
@legendecas @guangwong
src: split property helpers from node::Environment
a7c5bed 
PR-URL: nodejs/node#44056
Backport-PR-URL: nodejs/node#44542
Refs: nodejs/node#42528
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
Reviewed-By: Feng Yu <F3n67u@outlook.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
c++ Issues and PRs that require attention from people who are familiar with C++. lib / src Issues and PRs related to general changes in the lib or src directory. needs-ci PRs that need a full CI run.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@legendecas @nodejs-github-bot @richardlau