Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

worker: add no-worker-extension-check option #39785

Closed

Conversation

Ayase-252
Copy link
Member

Add no-work-extension-check CLI option to disable file extension check when starting a worker.

Fixes: #39124

cc @addaleax

@nodejs-github-bot nodejs-github-bot added c++ Issues and PRs that require attention from people who are familiar with C++. needs-ci PRs that need a full CI run. worker Issues and PRs related to Worker support. labels Aug 17, 2021
@devsnek
Copy link
Member

devsnek commented Aug 17, 2021

can we just remove the check altogether?

@Ayase-252
Copy link
Member Author

@devsnek of course can. opening an alternative PR.

@Ayase-252
Copy link
Member Author

Alternative opened on #39788

@Ayase-252
Copy link
Member Author

Closing in favor of #39788

@Ayase-252 Ayase-252 closed this Aug 17, 2021
@Ayase-252 Ayase-252 deleted the feature/worker/add-no-extension-check branch August 17, 2021 14:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
c++ Issues and PRs that require attention from people who are familiar with C++. needs-ci PRs that need a full CI run. worker Issues and PRs related to Worker support.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove extension check on Workers since they can run with require extensions
3 participants