Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix spelling in tools #16633

Closed
wants to merge 1 commit into from
Closed

fix spelling in tools #16633

wants to merge 1 commit into from

Conversation

bipinct
Copy link

@bipinct bipinct commented Oct 31, 2017

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • documentation is changed or added
  • commit message follows commit guidelines
Affected core subsystem(s)

@nodejs-github-bot nodejs-github-bot added build Issues and PRs related to build files or the CI. i18n-api Issues and PRs related to the i18n implementation. tools Issues and PRs related to the tools directory. labels Oct 31, 2017
Copy link
Member

@gireeshpunathil gireeshpunathil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The changes look good, I am not 100% sure whether these files come from upstream google or we maintain it ourselves. thoughts?

@joyeecheung
Copy link
Member

joyeecheung commented Oct 31, 2017

@gireeshpunathil Judging from the git log I think we maintain our own versions of gyp and icu, should be OK to modify them. CC @refack @srl295 @bnoordhuis

@gireeshpunathil gireeshpunathil mentioned this pull request Oct 31, 2017
2 tasks
@gibfahn
Copy link
Member

gibfahn commented Oct 31, 2017

Same comments as nodejs/node-gyp#1315 (comment) regarding commit username and email.

@refack
Copy link
Contributor

refack commented Oct 31, 2017

Both tools have an upstream "home" and we strive to minimize the number of "floating" patches we maintain on top of those:

@refack refack self-assigned this Oct 31, 2017
@gibfahn
Copy link
Member

gibfahn commented Oct 31, 2017

Both tools have an upstream "home" and we strive to minimize the number of "floating" patches we maintain on top of those:

Ahh, good to know. In that case @Bipin000 could you upstream this to https://gyp.gsrc.io/ first ?

@gibfahn gibfahn mentioned this pull request Oct 31, 2017
4 tasks
Copy link
Member

@gibfahn gibfahn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Making what I said in #16633 (comment) explicit (before someone lands this 😁 ).

This should be upstreamed to GYP first.

@BridgeAR
Copy link
Member

As this is only in the comments I do not see the necessity to land this. Instead I think there should be PRs upstream to fix this and we should just depend on that and not worry otherwise.

@Bipin000 that does not mean I do not appreciate your work! Thanks a lot for fixing it, I just think it is the wrong spot to do so.

@bipinct
Copy link
Author

bipinct commented Nov 25, 2017

@BridgeAR Thanks!!! I have pushed changes to GYP .

@bipinct bipinct closed this Nov 25, 2017
@refack refack removed their assignment Oct 12, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
build Issues and PRs related to build files or the CI. i18n-api Issues and PRs related to the i18n implementation. tools Issues and PRs related to the tools directory.
Projects
None yet
Development

Successfully merging this pull request may close these issues.