-
Notifications
You must be signed in to change notification settings - Fork 30.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix spelling in tools #16633
fix spelling in tools #16633
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The changes look good, I am not 100% sure whether these files come from upstream google or we maintain it ourselves. thoughts?
@gireeshpunathil Judging from the |
Same comments as nodejs/node-gyp#1315 (comment) regarding commit username and email. |
Both tools have an upstream "home" and we strive to minimize the number of "floating" patches we maintain on top of those: |
Ahh, good to know. In that case @Bipin000 could you upstream this to https://gyp.gsrc.io/ first ? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Making what I said in #16633 (comment) explicit (before someone lands this 😁 ).
This should be upstreamed to GYP first.
As this is only in the comments I do not see the necessity to land this. Instead I think there should be PRs upstream to fix this and we should just depend on that and not worry otherwise. @Bipin000 that does not mean I do not appreciate your work! Thanks a lot for fixing it, I just think it is the wrong spot to do so. |
@BridgeAR Thanks!!! I have pushed changes to GYP . |
Checklist
make -j4 test
(UNIX), orvcbuild test
(Windows) passesAffected core subsystem(s)