Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

doc: fix incorrect api version for Buffer.allocUnsafeSlow #15392

Closed
wants to merge 1 commit into from
Closed

doc: fix incorrect api version for Buffer.allocUnsafeSlow #15392

wants to merge 1 commit into from

Conversation

jwgoh
Copy link

@jwgoh jwgoh commented Sep 13, 2017 •
edited
Loading

Fixes: #15279

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • documentation is changed or added
  • commit message follows commit guidelines
Affected core subsystem(s)

doc

@nodejs-github-bot nodejs-github-bot added buffer Issues and PRs related to the buffer subsystem. doc Issues and PRs related to the documentations. labels Sep 13, 2017
@vsemozhetbyt
Copy link
Contributor

vsemozhetbyt commented Sep 13, 2017 •
edited
Loading

Hi, @jwgoh! Thank you for the contribution! Unfortunately, there is already a PR that addresses this issue: #15330 I am sorry we have not removed the good first contribution label when that PR had emerged. I hope you will not be discouraged and will make other contributions!

@jasnell
Copy link
Member

jasnell commented Sep 13, 2017

This likely does not need to wait the 48 hours to land.

@vsemozhetbyt
Copy link
Contributor

vsemozhetbyt commented Sep 13, 2017 •
edited
Loading

@jasnell It seems we have 2 PRs for this issue now.

@jwgoh
Copy link
Author

jwgoh commented Sep 13, 2017 •
edited
Loading

No worries @vsemozhetbyt, my bad, off to the next issue!

@jwgoh jwgoh closed this Sep 13, 2017
@jwgoh jwgoh deleted the doc/buffer branch September 13, 2017 15:28
@jasnell
Copy link
Member

jasnell commented Sep 13, 2017

heh... I thought it had looked familiar :-)

@vsemozhetbyt vsemozhetbyt mentioned this pull request Sep 13, 2017
Closed
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jasnell jasnell jasnell approved these changes

Assignees
No one assigned
Labels
buffer Issues and PRs related to the buffer subsystem. doc Issues and PRs related to the documentations.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Buffer.allocUnsafeSlow() allowed version in document is incorrect, actually is v5.12.0
4 participants
@jwgoh @vsemozhetbyt @jasnell @nodejs-github-bot