Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

doc - wrong history entry #15379

Closed
BridgeAR opened this issue Sep 13, 2017 · 0 comments
Closed

doc - wrong history entry #15379

BridgeAR opened this issue Sep 13, 2017 · 0 comments
Labels
doc Issues and PRs related to the documentations. good first issue Issues that are suitable for first-time contributors.

Comments

@BridgeAR
Copy link
Member

In the release notes of v.8.5.0 there is a small error (see a10856a#commitcomment-24266628).

I open this as good first contribution.
@BridgeAR BridgeAR added the good first issue Issues that are suitable for first-time contributors. label Sep 13, 2017
@BridgeAR BridgeAR changed the title assert - wrong history entry doc - wrong history entry Sep 13, 2017
@BridgeAR BridgeAR added the doc Issues and PRs related to the documentations. label Sep 13, 2017
@hisener hisener mentioned this issue Sep 13, 2017
Closed
4 tasks
addaleax pushed a commit to addaleax/ayo that referenced this issue Sep 17, 2017
@hisener @addaleax
doc: fix wrong history entry in deepStrictEqual
b6b6484 
PR-URL: nodejs/node#15381
Fixes: nodejs/node#15379
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Qard pushed a commit to Qard/ayo that referenced this issue Sep 21, 2017
@hisener
doc: fix wrong history entry in deepStrictEqual
bf57bc6 
PR-URL: nodejs/node#15381
Fixes: nodejs/node#15379
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
doc Issues and PRs related to the documentations. good first issue Issues that are suitable for first-time contributors.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

doc: fix wrong history entry in deepStrictEqual
1 participant
@BridgeAR