long term: install in a known spot

[srl295]

If you came here from the warning after installing full-icu please read:

• Long term solution is: detect "full-icu" module node#3460 (Feedback wanted)
• full-icu should detect that 3460 (above) has been merged (by node version) and do whatever needs to happen to write the dat file in the right spot.
• I'm not intending to deprecate full-icu, but to make it "do the right thing" going forward.

[icambron]

I'm a little confused. If I understood those instructions right, I just have to run that copy command and then when I run node I should have full ICU support? That's not what's happening for me at all. I'm on Node 8.1.2 and I'm getting:

new Intl.DateTimeFormat('es',{month:'long'}).format(new Date(9E8)) //=> "M01"

There are some other peculiarities: the instructions tell me to copy the file to ./node-modules/.node-icu but require('full-icu').datPath() give me /home/travis/build/icambron/luxon/icudt59l.dat. I'm just copying the file to both places, but nothing is working.

You can see my flailing here: https://travis-ci.org/icambron/luxon/builds/246657525. Am I just missing some key step?

Edit: nevermind, from searching around I discovered that the ICU auto-detection thing is sorta bunk and that I need to explicitly point Node at the ICU package.

[srl295]

@icambron says:

Edit: nevermind, from searching around I discovered that the ICU auto-detection thing is sorta bunk and that I need to explicitly point Node at the ICU package.

It's not bunk, it's just vaporware so far. There's a difference and help wanted @ nodejs/node#3460

[icambron]

Would you accept a smaller PR that just updated the instructions to tell the user to set the env var?

[srl295]

The main issue with 3460 is I haven't tested all of the possible environments it could break on and made the platform dependency as small as it should be. the proof of concept (auto detection) works fine.

@icambron do you mean an update to https://github.com/unicode-org/full-icu-npm/blob/master/README.md ?

When you install full-icu it prints out instructions to the console, doesn't it?

[icambron]

Ah, my bad: I hadn't rechecked the console instructions since writing my original comment above. I see now that the instructions have since been fixed by #15, which I guess is all I was suggesting doing in my vaguely-proposed PR. So all my confusion here is actually fixed by the updated console instructions. Sorry about the noise.

[srl295]

now that nodejs/node#3460 is closed and nodejs/node#19214 is landed, this module will hopefully see less and less use. I'm going to close this issue because it depends on 3460 to really make a difference.