ansible: add ClangCL to VS2022 fix #3786
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adds a missing VS component required for ClangCL compilation Refs: nodejs#3714 Refs: nodejs#3709
targos
approved these changes
Jun 26, 2024
richardlau
approved these changes
Jun 26, 2024
13 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a part of an effort to enable compilation with Clang on Windows. This commit allows for building with ClangCL in the CI.
This change is already applied to all VS2022 machines in the test and release CI. Note, that changing params for the win_chocolatey doesn't trigger installing a new component, so I installed these components manually on the existing machines.
Since the installation was done manually, the component I added in this PR was missing in Ansible. but was installed on the CI machines (previously I installed 2 components and only added 1 in Ansible).
Refs: #3714
Refs: #3709