Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
doc: add unhandled promise rejection survey #857
doc: add unhandled promise rejection survey #857
Changes from all commits
ce1e12b
69ae96b
4eea2a6
ac30722
892f43d
0c38bbc
3563cce
39fe167
84fe43e
69e1e5a
a7a8e68
5de9014
5ccb779
69d21d4
6848983
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@benjamingr what do you think?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There are a couple of technical inaccuracies here:
resolve
another promise with it in the promise constructor etc).But I think it's fine for us to be not 100% technically accurate when explaining terms and honestly we could keep talking about this for years :D
I think overall the survey is LGTM and I'm +1 on sending it.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We might want to add more possible situations here. Suggestions welcome :-)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I mean, I'd suggest GC again (
[ ] Warn as soon as possible and exit as soon as it can prove it is impossible to add a catch handler to the promise.
) but I'm afraid for my safety after how much backlash that suggestion got last time 😅There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is that something that can be implemented in userland? Otherwise it wouldn't fit the question.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We might want to add a note where
unhandled rejections
are described clearly to understand what they stand for?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think the introduction above covers that? I'm open to suggestions on how to improve it though.