Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reduce code duplication for ci-llama tests #1031

Draft
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

erman-gurses
Copy link

Currently it is a trial using action.yml

Signed-off-by: erman-gurses <erman@nod-labs.com>
@erman-gurses erman-gurses requested review from ScottTodd and marbre March 4, 2025 03:10
@ScottTodd ScottTodd requested a review from renxida March 4, 2025 17:33
Signed-off-by: erman-gurses <erman@nod-labs.com>
Copy link
Collaborator

@marbre marbre left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some first comments.

shell: bash
run: python -m venv ${{ inputs.venv-dir }}

- name: Install Dependencies
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You might want to cache those.

Copy link
Author

@erman-gurses erman-gurses Mar 5, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you please elaborate with an example?

Signed-off-by: erman-gurses <erman@nod-labs.com>
Signed-off-by: erman-gurses <erman@nod-labs.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants