Add more logging to sharktank data tests #1017
Draft
+68
−2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: erman-gurses <erman@nod-labs.com>
erman-gurses
added
the
infra
|
Will double check and add more logs for the other tests. |
|
@ScottTodd , raised a draft PR, let me know if you have any feedback. I can iterate over that. |
|
Can you link to example logs before/after in the PR description? That would make review easier. |
Signed-off-by: erman-gurses <erman@nod-labs.com>
Signed-off-by: erman-gurses <erman@nod-labs.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add more logging to sharktank data tests
It continues on this PR #917