Refactoring more GenerateService functions across shortfin apps #1010
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
KyleHerndon
changed the title
sogartar
approved these changes
Mar 4, 2025
Comment on lines
+177
to
+181
| self.name = None | ||
| self.model_params = None | ||
| self.prog_isolation = None | ||
| self.inference_programs = {} | ||
| self.inference_functions = {} |
There was a problem hiding this comment.
Could you add type hints on these?
| self.show_progress = False | ||
|
|
||
| # Worker and fiber configuration | ||
| self.workers = [] |
| *self.inference_modules[component], | ||
| ] | ||
|
|
||
| def create_program(self, modules, devices, isolation=None, trace_execution=None): |
| trace_execution=trace_execution, | ||
| ) | ||
|
|
||
| def create_worker(self, device, index): |
There was a problem hiding this comment.
Type hints on the arguments as well on the return.
Comment on lines
+66
to
+67
| inference_programs: dict[int, dict[str, sf.Program]] | ||
| inference_functions: dict[int, dict[str, sf.ProgramFunction]] |
There was a problem hiding this comment.
What is the point of this declarations? They are now moved to the base class.
Comment on lines
+34
to
+35
| inference_programs: dict[int, dict[str, sf.Program]] | ||
| inference_functions: dict[int, dict[str, sf.ProgramFunction]] |
There was a problem hiding this comment.
These are now part of the GenerateService base.
Comment on lines
+187
to
+189
| self.workers_per_device = 1 | ||
| self.fibers_per_device = 1 | ||
| self.fibers_per_worker = 1 |
There was a problem hiding this comment.
It would be cleaner if these were arguments to the __init__ function.
| """Base class for shortfin service implementations.""" | ||
|
|
||
| def __init__(self, sysman: SystemManager): | ||
| """Initialize base service attributes.""" | ||
| self.sysman = sysman | ||
| self.inference_parameters: dict[str, list[sf.BaseProgramParameters]] = {} | ||
| self.inference_modules: dict[str, list[sf.ProgramModule]] = {} | ||
| self.name = None | ||
| self.model_params = None |
There was a problem hiding this comment.
This should be an __init__ argument. Generally, the base class should be responsible for initialization of its members.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.