-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support owfs message type 'presence' #38
Conversation
Ping? |
Apologies; I completely forgot about this. Please can you fix the very minor style problem - that is why the Travis build failed. |
I fixed the small style-guide violation. sorry didn't see that initially. |
Yeah, I am bit stuck
|
Isn't eslint 'only' a style checker? So during runtime eslint has no influence. |
Yes, it is only a build-time dependency, not a run-time dependency. However there is a higher risk of depending on old/unsupported software depending on a package that steals your NPM key/bitcoins/SSH keys/password safe/documents. In ruby I have successfully changed dependencies based on the version of ruby but I am not sure how to achieve that with node - the configuration is JSON not JavaScript. The other issue is that the standard.js style guide changes when you upgrade it and it doesn't support older versions of node.js. I think maybe the solution is to take the configuration of an older version of standard.js and then stick to that. |
Or simply remove the support for node 4 + 5? Maybe this blog post gives some input: https://nodered.org/blog/2018/08/14/version-0-19-released "Node.js 4 reached its end-of-life back in April" |
I have done as you suggested and removed testing for Nodes version 4 and 5 and updated the README to say that node 6 or higher is required. Hopefully your PR will pass now... |
Can you please trigger a new travis CI run? I did not find any button to do this. |
Hm. I have tried triggering a rebuild a couple of times but it looks like it is still using the old .travis.yml file. Can you try rebasing your branch please? |
Useful to check the existence of 1-Wire devices like the DS2411.
OK. I rebased it. And now it is passing CI. |
Awesome, thanks for your persistence in getting this merged. |
Useful to check the existence of 1-Wire devices like the DS2411.
If you have any improvements, just let me know.
I would be happy if this change gets accepted.