Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support owfs message type 'presence' #38

Merged
merged 1 commit into from
Jan 26, 2019
Merged

Support owfs message type 'presence' #38

merged 1 commit into from
Jan 26, 2019

Conversation

waldbaer
Copy link
Contributor

Useful to check the existence of 1-Wire devices like the DS2411.

If you have any improvements, just let me know.
I would be happy if this change gets accepted.

@waldbaer
Copy link
Contributor Author

Ping?

@njh
Copy link
Owner

njh commented Jan 15, 2019

Apologies; I completely forgot about this.

Please can you fix the very minor style problem - that is why the Travis build failed.

@waldbaer
Copy link
Contributor Author

I fixed the small style-guide violation. sorry didn't see that initially.
Travis CI still fails for NPM versions 4 and 5. But this seems not to be related to my change. Looks like an issue in eslint for these NPM versions. Can you have a look on these errors?

@njh
Copy link
Owner

njh commented Jan 19, 2019

Yeah, I am bit stuck

  1. I want to support some older versions of node
  2. I want to use the latest versions of eslint / standard.js, to avoid security vulnerabilities
  3. There two seem to be incompatible 😢

@waldbaer
Copy link
Contributor Author

waldbaer commented Jan 21, 2019

Isn't eslint 'only' a style checker? So during runtime eslint has no influence.
I am no deep nodejs expert but maybe it is possible to use an older eslint version for CI tests with node 4 and 5?

@njh
Copy link
Owner

njh commented Jan 21, 2019

Yes, it is only a build-time dependency, not a run-time dependency. However there is a higher risk of depending on old/unsupported software depending on a package that steals your NPM key/bitcoins/SSH keys/password safe/documents.

In ruby I have successfully changed dependencies based on the version of ruby but I am not sure how to achieve that with node - the configuration is JSON not JavaScript.

The other issue is that the standard.js style guide changes when you upgrade it and it doesn't support older versions of node.js. I think maybe the solution is to take the configuration of an older version of standard.js and then stick to that.

@waldbaer
Copy link
Contributor Author

Or simply remove the support for node 4 + 5?
But I have no experience how many people / projects are still using these versions.

Maybe this blog post gives some input: https://nodered.org/blog/2018/08/14/version-0-19-released

"Node.js 4 reached its end-of-life back in April"

@njh
Copy link
Owner

njh commented Jan 23, 2019

I have done as you suggested and removed testing for Nodes version 4 and 5 and updated the README to say that node 6 or higher is required.

Hopefully your PR will pass now...

@waldbaer
Copy link
Contributor Author

Can you please trigger a new travis CI run? I did not find any button to do this.

@njh
Copy link
Owner

njh commented Jan 25, 2019

Hm. I have tried triggering a rebuild a couple of times but it looks like it is still using the old .travis.yml file.

Can you try rebasing your branch please?

Useful to check the existence of 1-Wire devices like the DS2411.
@waldbaer
Copy link
Contributor Author

OK. I rebased it. And now it is passing CI.

@njh njh merged commit c015e33 into njh:master Jan 26, 2019
@njh
Copy link
Owner

njh commented Jan 26, 2019

Awesome, thanks for your persistence in getting this merged.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants