Fix exception "cannot read property payload from undefined" #12
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -10,8 +10,12 @@ exports.extractValue = (callback) -> | |||
| else | |||
| messageToUse = messages | |||
| debug "message to use",messageToUse | |||
| result = messageToUse[0].payload.replace(new RegExp(" ", "g"), "") | |||
| callback(error, result) | |||
| if messages.length > 1 | |||
There was a problem hiding this comment.
Hi!
Thanks for the pull request. Please keep an eye on the failing travis ci build.
This should be >=1, otherwise results with exaclty one message will result in an error. This is the reason why the travis ci build for this pull request fails.
I will merge the PR when the tests are green.
Regards, Ben
|
Sorry, a stupid copy&paste error - of course we have to check 'messageToUse' to have a lenght greater than 0! |
benediktarnold
added a commit
that referenced
this pull request
Feb 4, 2015
Fix exception "cannot read property payload from undefined"
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Unfortunatly I cannot verfy if my coffee syntax is right, but I tried hard to code it right...
I changed my copy in build, which I didn't upload here, since "build" is only the result of coffee.
Without this fix, users randomly reported the given exception. Checking the code I found, that only return of an explicit error or the presence of more than 1 messages is being handled. Return of 0 messages without error would have lead to the exception.
You might consider to increase the version number after applying the patch ;)