-
-
Notifications
You must be signed in to change notification settings - Fork 1.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
bug: librewolf/firefox conflict #6467
Comments
You are broken by #6421 The fix is directionally correct (both apps use the same directory), but breaks when both apps are configured. This issue is very similar to what I'm trying to fix in #6460 (where I had conflict between thunderbird and firefox), but more work on top of it would be needed to allow multiple firefox derivatives at the same time. @khaneliman I wonder... should the offending PR be reverted until my PR that merges native hosts for all apps into one directory is merged and adopted for librewolf etc.? |
Ugh... this firefox nightmare. Yeah, we need to overhaul these to properly support multiple usages. |
What if we just merge the configurations in all definitions in a hidden option. |
Sometimes I regret splitting the Firefox derivations into separate modules 😅 As you said, this option should probably be merged. A configurable option alias could be a fix that works with the current setup. |
The issue itself was resolved with: nix-community#6460 This patch only adds a test case to make sure we don't ever regress by installing firefox and librewolf and floorp at the same time. Closes: nix-community#6467 Signed-off-by: Ihar Hrachyshka <ihar.hrachyshka@gmail.com>
I believe the issue was actually already fixed by #6460 ; I sent a patch that adds a test case to confirm it, but I see locally it passes already (and fails if I revert my merged PR). So please retry with the latest and confirm. @pshirshov |
That's what I was hoping while we were working through that. They should be using the shared option now. |
The issue itself was resolved with: nix-community#6460 This patch only adds a test case to make sure we don't ever regress by installing firefox and librewolf and floorp at the same time. Closes: nix-community#6467 Signed-off-by: Ihar Hrachyshka <ihar.hrachyshka@gmail.com>
The issue itself was resolved with: nix-community#6460 This patch only adds a test case to make sure we don't ever regress by installing firefox and librewolf and floorp at the same time. Closes: nix-community#6467 Signed-off-by: Ihar Hrachyshka <ihar.hrachyshka@gmail.com>
Are you following the right branch?
Is there an existing issue for this?
Issue description
I have both firefox and librewolf enabled. Today I've started getting these errors while trying to build:
It seems to be a regression, am I correct?
Maintainer CC
No response
System information
The text was updated successfully, but these errors were encountered: