-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add requirements.txt file for project dependencies #1
Open
kinow
wants to merge
1
commit into
niwa:master
Choose a base branch
from
kinow:add-requirementstxt
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Looks like |
I don’t think so, it might have been awhile ago but is not needed now, ive not installed it any previous deployment
From: Bruno P. Kinoshita [mailto:notifications@github.com]
Sent: Wednesday, 18 October 2017 10:07 p.m.
To: niwa/brukerpy_v2.0 <brukerpy_v2.0@noreply.github.com>
Cc: Subscribed <subscribed@noreply.github.com>
Subject: Re: [niwa/brukerpy_v2.0] Add requirements.txt file for project dependencies (#1)
Looks like pypiwin32 is also a requirement.
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub<#1 (comment)>, or mute the thread<https://github.com/notifications/unsubscribe-auth/AZg3RNpOOAGaOMwY-XckUxp0dzwpYY8aks5stb-mgaJpZM4P9W_H>.
Dr Alex Geddes
Atmospheric Scientist
+64-3-440-0408 | State Highway 85, Lauder, Central Otago | www.niwa.co.nz<http://www.niwa.co.nz>
[NIWA]<http://www.niwa.co.nz>
To ensure compliance with legal requirements and to maintain cyber security standards, NIWA's IT systems are subject to ongoing monitoring, activity logging and auditing. This monitoring and auditing service may be provided by third parties. Such third parties can access information transmitted to, processed by and stored on NIWA's IT systems.
|
Was looking at the imports in a few files and found this one https://github.com/niwa/brukerpy_v2.0/blob/5ee92ba342752519423ec47e2c393ee68a608985/exec_xpm.py#L11 But not sure if it's used or not. Still going through the documentation (which is really handy, thanks for putting it together). |
Yep it can definitely go, its how I used to do my dde link, I now have a dedicate ctypes script instead in the dde_client.py file.
Alex
From: Bruno P. Kinoshita [mailto:notifications@github.com]
Sent: Thursday, 19 October 2017 9:30 a.m.
To: niwa/brukerpy_v2.0 <brukerpy_v2.0@noreply.github.com>
Cc: Alex Geddes <Alex.Geddes@niwa.co.nz>; Comment <comment@noreply.github.com>
Subject: Re: [niwa/brukerpy_v2.0] Add requirements.txt file for project dependencies (#1)
Was looking at the imports in a few files and found this one https://github.com/niwa/brukerpy_v2.0/blob/5ee92ba342752519423ec47e2c393ee68a608985/exec_xpm.py#L11
But not sure if it's used or not. Still going through the documentation (which is really handy, thanks for putting it together).
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub<#1 (comment)>, or mute the thread<https://github.com/notifications/unsubscribe-auth/AZg3RMSPslN_E44BcY_UuedkcqtWNUVaks5stl_lgaJpZM4P9W_H>.
Dr Alex Geddes
Atmospheric Scientist
+64-3-440-0408 | State Highway 85, Lauder, Central Otago | www.niwa.co.nz<http://www.niwa.co.nz>
[NIWA]<http://www.niwa.co.nz>
To ensure compliance with legal requirements and to maintain cyber security standards, NIWA's IT systems are subject to ongoing monitoring, activity logging and auditing. This monitoring and auditing service may be provided by third parties. Such third parties can access information transmitted to, processed by and stored on NIWA's IT systems.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Extracted these dependencies from the BrukerPy guide V2 document. That way users can run
pip install -r requirements.txt