fix: Resolve crashes when running workflows with updatehash=True #3709
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #3709 +/- ##
==========================================
- Coverage 73.06% 73.04% -0.02%
==========================================
Files 1278 1278
Lines 59356 59357 +1
==========================================
- Hits 43367 43360 -7
- Misses 15989 15997 +8 ☔ View full report in Codecov by Sentry. |
Merged
effigies
approved these changes
Jan 19, 2025
Co-authored-by: Chris Markiewicz <effigies@gmail.com>
|
I add another commit to keep multi process functionality with updatehash=True. |
effigies
changed the title
effigies
added a commit
that referenced
this pull request
Mar 19, 2025
1.10.0 (March 19, 2025) New feature release in the 1.10.x series. This release adds GPUs to multiprocess resource management. In general, no changes to existing code should be required if the GPU-enabled interface has a ``use_gpu`` input. The ``n_gpu_procs`` can be used to set the number of GPU processes that may be run in parallel, which will override the default of GPUs identified by ``nvidia-smi``, or 1 if no GPUs are detected. * FIX: Reimplement ``gpu_count()`` (#3718) * FIX: Avoid 0D array in ``algorithms.misc.merge_rois`` (#3713) * FIX: Allow nipype.sphinx.ext.apidoc Config to work with Sphinx 8.2.1+ (#3716) * FIX: Resolve crashes when running workflows with updatehash=True (#3709) * ENH: Support for gpu queue (#3642) * ENH: Update to .wci.yml (#3708) * ENH: Add Workflow Community Initiative (WCI) descriptor (#3608)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Any workflow running with updatehash=True will crash
That happens because in nodes.py line 457 we try to update the hashfile even if the node was never executed before, so no hashfile is found and _update_hash function raises an exception.