CI: Set up build-test-deploy workflow on GHA #3513
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportBase: 65.25% // Head: 65.29% // Increases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## master #3513 +/- ##
==========================================
+ Coverage 65.25% 65.29% +0.03%
==========================================
Files 309 309
Lines 40873 40873
Branches 5380 5380
==========================================
+ Hits 26673 26687 +14
+ Misses 13126 13108 -18
- Partials 1074 1078 +4
Flags with carried forward coverage won't be shown. Click here to find out more.
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While futzing with the CI in the release branch, I realized we're currently doing things I no longer would recommend.
This moves us to a build-test-deploy workflow. The tests are broken into full tests across the supported Python range from the repository and an install-package-and-pytest test that will be more typical of downstream users or OS packagers. Finally, we upload if all tests pass.
I created an environment that allows us to manually review releases before pushing the package to PyPI, as this is the nibabel workflow, but given that we haven't been doing that so far I'm happy to revert to the "go on green" approach.