Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FIX: Delay access of nibabel.trackvis until actually needed #3488

Merged
merged 1 commit into from
Jul 12, 2022

Conversation

effigies
Copy link
Member

Closes #3486.

@codecov
Copy link

codecov bot commented Jul 12, 2022

Codecov Report

Merging #3488 (9f8e0b3) into master (3e7e613) will increase coverage by 16.73%.
The diff coverage is 0.00%.

@@             Coverage Diff             @@
##           master    #3488       +/-   ##
===========================================
+ Coverage   48.52%   65.25%   +16.73%     
===========================================
  Files         309      309               
  Lines       40848    40846        -2     
  Branches     5378     5378               
===========================================
+ Hits        19820    26655     +6835     
+ Misses      20897    13117     -7780     
- Partials      131     1074      +943     
Flag Coverage Δ
unittests 65.03% <0.00%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
nipype/interfaces/mrtrix/convert.py 15.73% <0.00%> (+14.22%) ⬆️
nipype/algorithms/mesh.py 29.70% <0.00%> (+0.49%) ⬆️
nipype/interfaces/camino/convert.py 71.92% <0.00%> (+0.76%) ⬆️
nipype/interfaces/dtitk/utils.py 92.66% <0.00%> (+0.91%) ⬆️
nipype/interfaces/cmtk/nbs.py 32.96% <0.00%> (+1.09%) ⬆️
nipype/pipeline/plugins/sge.py 18.10% <0.00%> (+1.29%) ⬆️
nipype/interfaces/freesurfer/petsurfer.py 77.45% <0.00%> (+1.73%) ⬆️
nipype/interfaces/mrtrix3/tracking.py 89.47% <0.00%> (+1.75%) ⬆️
nipype/interfaces/cmtk/cmtk.py 17.89% <0.00%> (+1.78%) ⬆️
nipype/interfaces/ants/visualization.py 87.75% <0.00%> (+2.04%) ⬆️
... and 110 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3e7e613...9f8e0b3. Read the comment docs.

@effigies effigies merged commit c388fae into nipy:master Jul 12, 2022
@effigies effigies deleted the fix/nibabel4 branch July 12, 2022 00:27
@effigies effigies mentioned this pull request Jul 14, 2022
8 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Compatibility with nibabel 4.0.0
1 participant