Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MAINT: Make pytest-xdist a dependency #2649

Merged
merged 1 commit into from
Jul 25, 2018
Merged

MAINT: Make pytest-xdist a dependency #2649

merged 1 commit into from
Jul 25, 2018

Conversation

djarecka
Copy link
Collaborator

Since we have pytest in REQUIRES I added also pytest-xdist, since this is now required to run nipype.test() (motivated by #2645)

@djarecka
Copy link
Collaborator Author

it's failing because of #2650

@oesteban
Copy link
Contributor

Why not moving the other way around? (pytest to TESTS_REQUIRES)

@djarecka
Copy link
Collaborator Author

@oesteban - sure, can do other way around. However, if I remember correctly some discussion when I was changing tests, we wanted user to be able to run nipype.test even after the most basic installation. am I wrong?

@oesteban
Copy link
Contributor

You are right. I'm happy either way, just to make sure we are doing this.

@effigies
Copy link
Member

Either way is fine with me. Strictly speaking, xdist shouldn't be a requirement, but it does seem to be causing people issues. My preferred option would probably be to disable -n auto if xdist isn't present, but that's probably not trivial.

Given how tightly integrated pytest is at this point, with the fixtures and all, having tests as first class components means it is a dependency. So if we can't decouple xdist, we should probably have it as a normal REQUIRES.

@effigies effigies added this to the 1.1.1 milestone Jul 25, 2018
@djarecka
Copy link
Collaborator Author

@effigies I think you can't use -n flag at all if you don't have xdist. We can always check if xdist is available and based on this change the pytest command. On the other hand, I don't know if we have a good reason to avoid xdist in the requirements (I mean we're asking for many outside standard library packages anyway)

@effigies effigies changed the title moving pytest-xdist from TESTS_REQUIRES to REQUIRES MAINT: Make pytest-xdist a dependency Jul 25, 2018
@effigies effigies merged commit 4b2a821 into nipy:master Jul 25, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants