enh: add interface for LabelGeometryMeasures #2586
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #2586 +/- ##
==========================================
+ Coverage 67.57% 67.58% +<.01%
==========================================
Files 335 335
Lines 42601 42612 +11
Branches 5269 5269
==========================================
+ Hits 28788 28799 +11
+ Misses 13140 13132 -8
- Partials 673 681 +8
Continue to review full report at Codecov.
|
effigies
approved these changes
May 19, 2018
| desc='label image to use for extracting geometry measures') | ||
| intensity_image = File( | ||
| value='[]', | ||
| exists=True, |
There was a problem hiding this comment.
exists=True seems weird, given a default value of '[]'. I guess it applies only to non-default values?
There was a problem hiding this comment.
exists only applies to non-default values (could be considered a bug). i'm taking advantage of that here, without writing a _format_arg function, but something to keep in mind.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes proposed in this pull request