Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix catmatvec #2527

Merged
merged 4 commits into from
Apr 4, 2018
Merged

Fix catmatvec #2527

merged 4 commits into from
Apr 4, 2018

Conversation

salma1601
Copy link
Contributor

Fixes #2526 .

Changes proposed in this pull request

  • use name_template and name_source for generating the out_file
  • add _list_outputs method

@effigies effigies added this to the 1.0.3 milestone Apr 3, 2018
@codecov-io
Copy link

codecov-io commented Apr 3, 2018

Codecov Report

Merging #2527 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #2527   +/-   ##
=======================================
  Coverage   66.88%   66.88%           
=======================================
  Files         327      327           
  Lines       42490    42490           
  Branches     5269     5269           
=======================================
  Hits        28421    28421           
  Misses      13367    13367           
  Partials      702      702
Flag Coverage Δ
#smoketests 50.85% <ø> (ø) ⬆️
#unittests 64.23% <ø> (-0.01%) ⬇️
Impacted Files Coverage Δ
nipype/interfaces/afni/utils.py 81.55% <ø> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e446466...694d855. Read the comment docs.

@mgxd
Copy link
Member

mgxd commented Apr 3, 2018

@salma1601 have you tried this without adding the _list_outputs method? I believe it should still work

@salma1601
Copy link
Contributor Author

@salma1601 have you tried this without adding the _list_outputs method? I believe it should still work

yes and you are right, it works without it ! removed

@@ -616,7 +619,6 @@ def _format_arg(self, name, spec, value):
for i in value]))
return super(CatMatvec, self)._format_arg(name, spec, value)


Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you re-add this line?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes sorry

Copy link
Member

@mgxd mgxd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@effigies effigies merged commit d69bfd2 into nipy:master Apr 4, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants