fix: handle automatic module creation, name extraction, default value

[satra]

Fixes #2488

Changes proposed in this pull request

• fix the error
• generate a test (this is a little tricky - i can generate a very specific test, but that's not a long term solution)

[satra]

@effigies - this is stumping me right now. if it's an str object why would it be in the else clause? any ideas?

        # Retrieves Nipype interface

        if isinstance(module, str):
            import_module(module)
            module_name = str(module)
            module = sys.modules[module]
        else:
>           module_name = str(module.__name__)
E           AttributeError: 'str' object has no attribute '__name__'

[effigies]

Is this a builtins.str issue somehow?

[satra]

possibly - downloading the latest container to test locally.

[effigies]

Just looked at this on something that isn't a phone.

% python2.7 -c "from builtins import str; print(isinstance('test', str))"
False

So I think you'll need to do isinstance(module, (str, bytes)).

[codecov-io]

Codecov Report

Merging #2490 into master will increase coverage by 0.16%.
The diff coverage is 33.33%.

@@            Coverage Diff             @@
##           master    #2490      +/-   ##
==========================================
+ Coverage   66.66%   66.82%   +0.16%     
==========================================
  Files         328      328              
  Lines       42529    42532       +3     
  Branches     5278     5279       +1     
==========================================
+ Hits        28350    28422      +72     
+ Misses      13500    13411      -89     
- Partials      679      699      +20

Flag	Coverage Δ
#smoketests	50.48% <ø> (-0.31%)	⬇️
#unittests	64.18% <33.33%> (+0.2%)	⬆️

Impacted Files	Coverage Δ
nipype/utils/nipype2boutiques.py	68.38% <33.33%> (+56.35%)	⬆️
nipype/workflows/fmri/spm/preprocess.py	60.2% <0%> (-12.25%)	⬇️
nipype/utils/provenance.py	83.43% <0%> (-1.28%)	⬇️
nipype/pipeline/engine/nodes.py	83.58% <0%> (-0.34%)	⬇️
nipype/interfaces/ants/registration.py	74.12% <0%> (+1.03%)	⬆️
nipype/interfaces/ants/base.py	72.34% <0%> (+10.63%)	⬆️
nipype/scripts/instance.py	56.25% <0%> (+18.75%)	⬆️

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 88dbce1...7f38e40. Read the comment docs.

[satra]

@gkiar - i'm merging this one for now to resolve at least basic problem. but we should work towards a better solution.