Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FIX: Update pybids data directory, unbundle out-of-date numpydoc #2437

Merged
merged 2 commits into from
Feb 12, 2018

Conversation

effigies
Copy link
Member

Fixes failing Travis builds that depend on sample data in pybids.

Changes proposed in this pull request

  • Update pybids data directory

@effigies
Copy link
Member Author

Getting the following error on Circle:

Could not import extension numpy_ext.numpydoc (exception: No module named 'sphinx.util.compat')

Appears that we're manually packaging an old version of numpydoc. I'm switching to the release version, to see if that fixes things. @satra let me know if there's a reason we haven't been doing this up to now.

@satra
Copy link
Member

satra commented Feb 12, 2018

@effigies - when nipype was created a lot of things were copied over from hacks people had implemented. i suspect this was another of those things.

@effigies effigies force-pushed the test/update_bids_data branch from ea41641 to f1e0b19 Compare February 12, 2018 15:44
@effigies effigies changed the title FIX: Update pybids data directory FIX: Update pybids data directory, unbundle out-of-date numpydoc Feb 12, 2018
@effigies
Copy link
Member Author

Docs seem to build fine. Good to merge?

@oesteban
Copy link
Contributor

@effigies, you were right: sphinx 1.7.0 has discontinued sphinx.util.compat. For nipype, upgrading numpydoc did the trick.

@effigies effigies added this to the 1.0.1 milestone Feb 13, 2018
@effigies effigies deleted the test/update_bids_data branch February 13, 2018 16:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants