FIX,REF: BIDSDataGrabber #2336
Merged
FIX,REF: BIDSDataGrabber #2336
+201
−205
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mgxd
approved these changes
Dec 18, 2017
There was a problem hiding this comment.
I am very in favor of this, the api change shouldn't be a huge deal since this is a relatively new interface but I'll let a second pair of eyes merge this.
One suggestion is adding this interface to the interface level __init__ for easier import?
https://github.com/nipy/nipype/blob/master/nipype/interfaces/__init__.py#L12
| "anat": {"modality": "anat"}} | ||
|
|
||
| # If infields is empty, use all BIDS entities | ||
| if infields is None and have_pybids: |
| @@ -1,147 +0,0 @@ | |||
| # -*- coding: utf-8 -*- | |||
There was a problem hiding this comment.
I am okay with this change - but removing this is an api change from 0.14 @satra WDYT
|
@mvdoc This would be good to get fixed before 1.0 (hoping to release tomorrow). |
|
!!! 1.0 !!! OK, will fix asap |
mvdoc
force-pushed
the
bidsdatagrabber
branch
from
61116d2 to
3352ae6
Compare
* 'master' of github.com:nipy/nipype: fix error type remove install_aliases sty fix tests refactoring tests update changes [MAINT] Cleanup engine/base
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2333 .
Changes proposed in this pull request
BIDSDataGrabbertointerfaces.iofor consistency, and also for usingIOBaseas a base class (otherwise failed for circular import)infieldswas set, it was populated anyway by Pybids defaultsBIDSDataGrabberis now subclass ofIOBaseinstead ofBaseInterface